| Message ID | 20200221004134.30599-4-ira.weiny@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Enable per-file/per-directory DAX operations V4 | expand |
On Thu, Feb 20, 2020 at 04:41:24PM -0800, ira.weiny@intel.com wrote: > From: Ira Weiny <ira.weiny@intel.com> > > Remove the check because DAX now has it's own read/write methods and > file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on > their own. Therefore, it does not matter if the file state is DAX when > the iocb flags are created. > > Reviewed-by: Jan Kara <jack@suse.cz> > Signed-off-by: Ira Weiny <ira.weiny@intel.com> Yup, looks good. Reviewed-by: Dave Chinner <dchinner@redhat.com>
On Thu, Feb 20, 2020 at 04:41:24PM -0800, ira.weiny@intel.com wrote: > From: Ira Weiny <ira.weiny@intel.com> > > Remove the check because DAX now has it's own read/write methods and > file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on > their own. Therefore, it does not matter if the file state is DAX when > the iocb flags are created. > > Reviewed-by: Jan Kara <jack@suse.cz> > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > > --- > Changes from v3: > Reword commit message. > Reordered to be a 'pre-cleanup' patch > --- > include/linux/fs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index 3cd4fe6b845e..63d1e533a07d 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -3388,7 +3388,7 @@ extern int file_update_time(struct file *file); > > static inline bool io_is_direct(struct file *filp) > { > - return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host); > + return (filp->f_flags & O_DIRECT); Please just kill io_is_direct entirely.
On Fri, Feb 21, 2020 at 12:42:25PM +1100, Dave Chinner wrote: > On Thu, Feb 20, 2020 at 04:41:24PM -0800, ira.weiny@intel.com wrote: > > From: Ira Weiny <ira.weiny@intel.com> > > > > Remove the check because DAX now has it's own read/write methods and > > file systems which support DAX check IS_DAX() prior to IOCB_DIRECT on > > their own. Therefore, it does not matter if the file state is DAX when > > the iocb flags are created. > > > > Reviewed-by: Jan Kara <jack@suse.cz> > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > > Yup, looks good. > > Reviewed-by: Dave Chinner <dchinner@redhat.com> Thanks, Ira > -- > Dave Chinner > david@fromorbit.com
diff --git a/include/linux/fs.h b/include/linux/fs.h index 3cd4fe6b845e..63d1e533a07d 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -3388,7 +3388,7 @@ extern int file_update_time(struct file *file); static inline bool io_is_direct(struct file *filp) { - return (filp->f_flags & O_DIRECT) || IS_DAX(filp->f_mapping->host); + return (filp->f_flags & O_DIRECT); } static inline bool vma_is_dax(struct vm_area_struct *vma)