| Message ID | 20200116140108.6069-1-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/2] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage | expand |
On Thu, Jan 16, 2020 at 03:01:07PM +0100, Marco Felsch wrote: > The current set minimum voltage of 730000µV seems to be wrong. I don't > know the document which specifies that but the imx6qdl datasheets says > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> I failed to apply it. Please rebase and resend. Shawn > --- > v3: > - fix commit message > v2: > - use ldo bypassed values > --- > arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > index a1e2c5094d58..51a47a242783 100644 > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > @@ -111,14 +111,14 @@ > regulators { > vdd_arm: buck1 { > regulator-name = "vdd_arm"; > - regulator-min-microvolt = <730000>; > + regulator-min-microvolt = <925000>; > regulator-max-microvolt = <1380000>; > regulator-always-on; > }; > > vdd_soc: buck2 { > regulator-name = "vdd_soc"; > - regulator-min-microvolt = <730000>; > + regulator-min-microvolt = <1150000>; > regulator-max-microvolt = <1380000>; > regulator-always-on; > }; > -- > 2.20.1 >
Hi Shawn, On 20-02-13 20:59, Shawn Guo wrote: > On Thu, Jan 16, 2020 at 03:01:07PM +0100, Marco Felsch wrote: > > The current set minimum voltage of 730000µV seems to be wrong. I don't > > know the document which specifies that but the imx6qdl datasheets says > > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, > > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). > > > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > I failed to apply it. Please rebase and resend. Which base commit did you use? I rebased the patch on v5.6-rc1 without problems. Regards, Marco > Shawn > > > --- > > v3: > > - fix commit message > > v2: > > - use ldo bypassed values > > --- > > arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > > index a1e2c5094d58..51a47a242783 100644 > > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > > @@ -111,14 +111,14 @@ > > regulators { > > vdd_arm: buck1 { > > regulator-name = "vdd_arm"; > > - regulator-min-microvolt = <730000>; > > + regulator-min-microvolt = <925000>; > > regulator-max-microvolt = <1380000>; > > regulator-always-on; > > }; > > > > vdd_soc: buck2 { > > regulator-name = "vdd_soc"; > > - regulator-min-microvolt = <730000>; > > + regulator-min-microvolt = <1150000>; > > regulator-max-microvolt = <1380000>; > > regulator-always-on; > > }; > > -- > > 2.20.1 > > >
On Fri, Feb 21, 2020 at 08:27:51AM +0100, Marco Felsch wrote: > Hi Shawn, > > On 20-02-13 20:59, Shawn Guo wrote: > > On Thu, Jan 16, 2020 at 03:01:07PM +0100, Marco Felsch wrote: > > > The current set minimum voltage of 730000µV seems to be wrong. I don't > > > know the document which specifies that but the imx6qdl datasheets says > > > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, > > > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). > > > > > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > > > I failed to apply it. Please rebase and resend. > > Which base commit did you use? I rebased the patch on v5.6-rc1 without > problems. But 'git am' fails on v5.6-rc1. Applying: ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage error: patch failed: arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi:111 error: arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi: patch does not apply Patch failed at 0001 ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Shawn
On 20-02-24 09:06, Shawn Guo wrote: > On Fri, Feb 21, 2020 at 08:27:51AM +0100, Marco Felsch wrote: > > Hi Shawn, > > > > On 20-02-13 20:59, Shawn Guo wrote: > > > On Thu, Jan 16, 2020 at 03:01:07PM +0100, Marco Felsch wrote: > > > > The current set minimum voltage of 730000µV seems to be wrong. I don't > > > > know the document which specifies that but the imx6qdl datasheets says > > > > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, > > > > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). > > > > > > > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") > > > > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > > > > > > I failed to apply it. Please rebase and resend. > > > > Which base commit did you use? I rebased the patch on v5.6-rc1 without > > problems. > > But 'git am' fails on v5.6-rc1. Mh.. don't see why git am complains on my side.. Anyway I will send a new version =) Regards, Marco > Applying: ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage > error: patch failed: arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi:111 > error: arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi: patch does not apply > Patch failed at 0001 ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage > Use 'git am --show-current-patch' to see the failed patch > When you have resolved this problem, run "git am --continue". > If you prefer to skip this patch, run "git am --skip" instead. > To restore the original branch and stop patching, run "git am --abort". > > Shawn
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi index a1e2c5094d58..51a47a242783 100644 --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi @@ -111,14 +111,14 @@ regulators { vdd_arm: buck1 { regulator-name = "vdd_arm"; - regulator-min-microvolt = <730000>; + regulator-min-microvolt = <925000>; regulator-max-microvolt = <1380000>; regulator-always-on; }; vdd_soc: buck2 { regulator-name = "vdd_soc"; - regulator-min-microvolt = <730000>; + regulator-min-microvolt = <1150000>; regulator-max-microvolt = <1380000>; regulator-always-on; };
The current set minimum voltage of 730000µV seems to be wrong. I don't know the document which specifies that but the imx6qdl datasheets says that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- v3: - fix commit message v2: - use ldo bypassed values --- arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)