| Message ID | 1582266716-19821-1-git-send-email-Anson.Huang@nxp.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 530cf8d49f2a650625eee6ce28793bd7974e14bd |
| Headers | show |
| Series | clk: imx: pll14xx: Return error if pll type is invalid | expand |
Quoting Anson Huang (2020-02-20 22:31:56) > When pll type is invalid, ONLY output error message is NOT enough, > should return error immediately. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> > --- Reviewed-by: Stephen Boyd <sboyd@kernel.org>
On Fri, Feb 21, 2020 at 02:31:56PM +0800, Anson Huang wrote: > When pll type is invalid, ONLY output error message is NOT enough, > should return error immediately. > > Signed-off-by: Anson Huang <Anson.Huang@nxp.com> Applied, thanks.
diff --git a/drivers/clk/imx/clk-pll14xx.c b/drivers/clk/imx/clk-pll14xx.c index 37e311e..a83bbbe 100644 --- a/drivers/clk/imx/clk-pll14xx.c +++ b/drivers/clk/imx/clk-pll14xx.c @@ -410,6 +410,8 @@ struct clk_hw *imx_clk_hw_pll14xx(const char *name, const char *parent_name, default: pr_err("%s: Unknown pll type for pll clk %s\n", __func__, name); + kfree(pll); + return ERR_PTR(-EINVAL); }; pll->base = base;
When pll type is invalid, ONLY output error message is NOT enough, should return error immediately. Signed-off-by: Anson Huang <Anson.Huang@nxp.com> --- drivers/clk/imx/clk-pll14xx.c | 2 ++ 1 file changed, 2 insertions(+)