| Message ID | 20200219022852.28065-1-vadivel.muruganx.ramuthevar@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | spi: cadence-quadpsi: Add support for the Cadence QSPI controller | expand |
On 2/19/20 3:28 AM, Ramuthevar,Vadivel MuruganX wrote: > Add support for the Cadence QSPI controller. This controller is > present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs. > This driver has been tested on the Intel LGM SoCs. > > This driver does not support generic SPI and also the implementation > only supports spi-mem interface to replace the existing driver in > mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR > flash memory. > > Thanks Mark and Vignesh for the review, suggestion to optimize the patch. > Tested with mx25u12835f on LGM platform. There is a typo in the subject -- it's quadspi , not quadpsi.
Hi, On 19/02/20 7:58 am, Ramuthevar,Vadivel MuruganX wrote: [...] > CHECK Documentation/devicetree/bindings/spi/cdns,qspi-nor.example.dt.yaml > > Ramuthevar Vadivel Murugan (2): > dt-bindings: spi: Add schema for Cadence QSPI Controller driver > spi: cadence-quadpsi: Add support for the Cadence QSPI controller > > .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 147 +++++ > drivers/mtd/spi-nor/Kconfig | 11 - > drivers/mtd/spi-nor/Makefile | 1 - > drivers/spi/Kconfig | 8 + > drivers/spi/Makefile | 1 + > .../spi-cadence-quadspi.c} | 641 ++++++++++----------- > 6 files changed, 459 insertions(+), 350 deletions(-) > create mode 100644 Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml You will have to remove old bindings as well. Also please CC linux-mtd list as these patches touch drivers/mtd/* Just run scripts/get_maintainer.pl on your patches to get list of mailing list and people to CC > rename drivers/{mtd/spi-nor/cadence-quadspi.c => spi/spi-cadence-quadspi.c} (73%) >
Hi, On 25/2/2020 12:23 PM, Vignesh Raghavendra wrote: > Hi, > > On 19/02/20 7:58 am, Ramuthevar,Vadivel MuruganX wrote: > [...] >> CHECK Documentation/devicetree/bindings/spi/cdns,qspi-nor.example.dt.yaml >> >> Ramuthevar Vadivel Murugan (2): >> dt-bindings: spi: Add schema for Cadence QSPI Controller driver >> spi: cadence-quadpsi: Add support for the Cadence QSPI controller >> >> .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 147 +++++ >> drivers/mtd/spi-nor/Kconfig | 11 - >> drivers/mtd/spi-nor/Makefile | 1 - >> drivers/spi/Kconfig | 8 + >> drivers/spi/Makefile | 1 + >> .../spi-cadence-quadspi.c} | 641 ++++++++++----------- >> 6 files changed, 459 insertions(+), 350 deletions(-) >> create mode 100644 Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml > You will have to remove old bindings as well. Also please CC linux-mtd > list as these patches touch drivers/mtd/* Sure, will remove old bindings. Agree!, cc of linux-mtd list. > > Just run scripts/get_maintainer.pl on your patches to get list of > mailing list and people to CC Thanks for the commands. Regards Vadivel >> rename drivers/{mtd/spi-nor/cadence-quadspi.c => spi/spi-cadence-quadspi.c} (73%) >>
Add support for the Cadence QSPI controller. This controller is present in the Intel Lightning Mountain(LGM) SoCs, Altera and TI SoCs. This driver has been tested on the Intel LGM SoCs. This driver does not support generic SPI and also the implementation only supports spi-mem interface to replace the existing driver in mtd/spi-nor/cadence-quadspi.c, the existing driver only support SPI-NOR flash memory. Thanks Mark and Vignesh for the review, suggestion to optimize the patch. Tested with mx25u12835f on LGM platform. changes from v9: -- Mark's review comments address -- add check to shared interrupt handler -- add check decoder if present -- add error check for quirks capability data -- remove the existing cadence_quadspi.c from drivers/mtd/spi-nor path -- remove CONFIG macro from Kconfig in the above path -- remove cadence_quadspi.o build option from Makefile in the above path changes from v8: -- remove the depends MTD macro -- comment into C++ style -- remove spaces and tabs where not applicable. -- align the macro string as same as existing one. -- replace QUAD to op->data.buswidth variable. -- add CQSPI_NEEDS_ADDR_SWAP instead of soc_selection variable changes from v7: -- remove addr_buf kept like as original -- drop bus-num, chipselect variable -- add soc_selection varible to differetiate the features -- replace dev->ddev in dma function -- add seperate function to handle the 24bit slave device address translation for lgm soc -- correct sentence seems incomplete in Kconfig -- add cqspi->soc_selection check to keep the original TI platform working code. changes from v6: -- Add the Signed-off-by Vignesh in commit message -- bus_num, num_chipselect added to avoid the garbage bus number during the probe and spi_register. -- master mode bits updated -- address sequence is different from TI and Intel SoC Ip handling so modified as per Intel and differentiating by use_dac_mode variable. -- dummy cycles also different b/w two platforms, so keeping separate check -- checkpatch errors which are intentional left as is for better readability changes from v5: -- kbuild test robot warnings fixed -- Add Reported-By: Dan Carpenter <dan.carpenter@oracle.com> changes from v4: -- kbuild test robot warnings fixed -- Add Reborted-by: tag changes from v3: spi-cadence-quadspi.c -- static to all functions wrt to local to the file. -- Prefix cqspi_ and make the function static -- cmd_ops, data_ops and dummy_ops dropped -- addr_ops kept since it is required for address calculation. -- devm_ used for supported functions , removed legacy API's -- removed "indirect" name from functions -- replaced by master->mode_bits = SPI_RX_QUAD | SPI_TX_DUAL | SPI_RX_DUAL | SPI_RX_OCTAL; as per Vignesh susggestion -- removed free functions since devm_ handles automatically. -- dropped all unused Macros YAML file update: -- cadence,qspi.yaml file name replace by cdns,qspi-nor.yaml -- compatible string updated as per Vignesh suggestion -- for single entry, removed descriptions -- removed optional parameters Build Result: linux$ make DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml dt_binding_check CHKDT Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml SCHEMA Documentation/devicetree/bindings/processed-schema.yaml DTC Documentation/devicetree/bindings/spi/cdns,qspi-nor.example.dt.yaml CHECK Documentation/devicetree/bindings/spi/cdns,qspi-nor.example.dt.yaml Ramuthevar Vadivel Murugan (2): dt-bindings: spi: Add schema for Cadence QSPI Controller driver spi: cadence-quadpsi: Add support for the Cadence QSPI controller .../devicetree/bindings/spi/cdns,qspi-nor.yaml | 147 +++++ drivers/mtd/spi-nor/Kconfig | 11 - drivers/mtd/spi-nor/Makefile | 1 - drivers/spi/Kconfig | 8 + drivers/spi/Makefile | 1 + .../spi-cadence-quadspi.c} | 641 ++++++++++----------- 6 files changed, 459 insertions(+), 350 deletions(-) create mode 100644 Documentation/devicetree/bindings/spi/cdns,qspi-nor.yaml rename drivers/{mtd/spi-nor/cadence-quadspi.c => spi/spi-cadence-quadspi.c} (73%)