diff mbox series

drm/tidss: Use drm_for_each_bridge_in_chain()

Message ID 20200222110718.26272-1-laurent.pinchart@ideasonboard.com (mailing list archive)
State New, archived
Headers show
Series drm/tidss: Use drm_for_each_bridge_in_chain() | expand

Commit Message

Laurent Pinchart Feb. 22, 2020, 11:07 a.m. UTC
Replace the manual encoder->bridge_chain walk with the
drm_for_each_bridge_in_chain() macro. Drivers should not touch the
bridge_chain field directly.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
---
 drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jyri Sarha Feb. 27, 2020, 10 a.m. UTC | #1
On 22/02/2020 13:07, Laurent Pinchart wrote:
> Replace the manual encoder->bridge_chain walk with the
> drm_for_each_bridge_in_chain() macro. Drivers should not touch the
> bridge_chain field directly.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Reviewed-by: Jyri Sarha <jsarha@ti.com>
Tested-by: Jyri Sarha <jsarha@ti.com>

I'll merge this to drm-misc-next tomorrow.

Thank you for the patch,
Jyri

> ---
>  drivers/gpu/drm/tidss/tidss_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c b/drivers/gpu/drm/tidss/tidss_encoder.c
> index f7fe3a43ead0..83785b0a66a9 100644
> --- a/drivers/gpu/drm/tidss/tidss_encoder.c
> +++ b/drivers/gpu/drm/tidss/tidss_encoder.c
> @@ -32,7 +32,7 @@ static int tidss_encoder_atomic_check(struct drm_encoder *encoder,
>  	 * bridge timings, or from the connector's display_info if no
>  	 * bridge defines the timings.
>  	 */
> -	list_for_each_entry(bridge, &encoder->bridge_chain, chain_node) {
> +	drm_for_each_bridge_in_chain(encoder, bridge) {
>  		if (!bridge->timings)
>  			continue;
>  
>
diff mbox series

Patch

diff --git a/drivers/gpu/drm/tidss/tidss_encoder.c b/drivers/gpu/drm/tidss/tidss_encoder.c
index f7fe3a43ead0..83785b0a66a9 100644
--- a/drivers/gpu/drm/tidss/tidss_encoder.c
+++ b/drivers/gpu/drm/tidss/tidss_encoder.c
@@ -32,7 +32,7 @@  static int tidss_encoder_atomic_check(struct drm_encoder *encoder,
 	 * bridge timings, or from the connector's display_info if no
 	 * bridge defines the timings.
 	 */
-	list_for_each_entry(bridge, &encoder->bridge_chain, chain_node) {
+	drm_for_each_bridge_in_chain(encoder, bridge) {
 		if (!bridge->timings)
 			continue;