mbox series

[00/20] hw: Clean up hw/i386 headers (and few alpha/hppa)

Message ID 20191014142246.4538-1-philmd@redhat.com (mailing list archive)
Headers show
Series hw: Clean up hw/i386 headers (and few alpha/hppa) | expand

Message

Philippe Mathieu-Daudé Oct. 14, 2019, 2:22 p.m. UTC
This is a follow-up of Markus's cleanup series:
Tame a few "touch this, recompile the world"
https://www.mail-archive.com/qemu-devel@nongnu.org/msg635748.html

This part is mostly restricted to X86, but since some file from the
Alpha/PA-RISC machines include "hw/i386/pc.h" I had to fix them
too.

Eventually I'll succeed at removing hw/i386/ dependency on non-X86
platforms (Quest I started 2 years ago...).

Regards,

Phil.

Philippe Mathieu-Daudé (20):
  vl: Add missing "hw/boards.h" include
  hw/southbridge/ich9: Removed unused headers
  hw/input/pckbd: Remove unused "hw/i386/pc.h" header
  hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
  hw/timer: Remove unused "ui/console.h" header
  hw/usb/dev-storage: Remove unused "ui/console.h" header
  hw/i386/intel_iommu: Remove unused includes
  hw/xen/xen_pt_load_rom: Remove unused includes
  hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
  hw/alpha/dp264: Include "net/net.h"
  hw/hppa/machine: Include "net/net.h"
  hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
  hw/timer/hpet: Include "exec/address-spaces.h"
  hw/pci-host/q35: Include "qemu/range.h"
  hw/i2c/smbus_ich9: Include "qemu/range.h"
  hw/pci-host/piix: Include "qemu/range.h"
  hw/acpi: Include "hw/mem/nvdimm.h"
  hw/i386: Include "hw/mem/nvdimm.h"
  hw/pci-host/q35: Remove unused includes
  hw/i386/pc: Clean up includes

 hw/acpi/cpu_hotplug.c             |  1 +
 hw/acpi/ich9.c                    |  2 +-
 hw/acpi/piix4.c                   |  1 +
 hw/alpha/alpha_sys.h              |  1 -
 hw/alpha/dp264.c                  |  1 +
 hw/hppa/machine.c                 |  1 +
 hw/i2c/smbus_ich9.c               |  1 +
 hw/i386/acpi-build.c              |  1 +
 hw/i386/pc.c                      |  1 +
 hw/i386/pc_piix.c                 |  1 +
 hw/i386/pc_q35.c                  |  1 +
 hw/input/pckbd.c                  |  1 -
 hw/isa/lpc_ich9.c                 |  2 --
 hw/pci-host/piix.c                |  1 +
 hw/pci-host/q35.c                 |  1 +
 hw/timer/hpet.c                   |  2 +-
 hw/timer/twl92230.c               |  1 -
 hw/usb/dev-storage.c              |  1 -
 hw/xen/xen_pt_load_rom.c          |  4 ----
 include/hw/i386/ich9.h            |  1 -
 include/hw/i386/intel_iommu.h     |  4 ----
 include/hw/i386/ioapic_internal.h |  1 -
 include/hw/i386/pc.h              | 12 +++---------
 include/hw/pci-host/q35.h         |  8 +-------
 vl.c                              |  1 +
 25 files changed, 18 insertions(+), 34 deletions(-)

Comments

John Snow Oct. 14, 2019, 5:03 p.m. UTC | #1
On 10/14/19 10:22 AM, Philippe Mathieu-Daudé wrote:
> This is a follow-up of Markus's cleanup series:
> Tame a few "touch this, recompile the world"
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg635748.html
> 
> This part is mostly restricted to X86, but since some file from the
> Alpha/PA-RISC machines include "hw/i386/pc.h" I had to fix them
> too.
> 
> Eventually I'll succeed at removing hw/i386/ dependency on non-X86
> platforms (Quest I started 2 years ago...).
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (20):
>   vl: Add missing "hw/boards.h" include
>   hw/southbridge/ich9: Removed unused headers
>   hw/input/pckbd: Remove unused "hw/i386/pc.h" header
>   hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
>   hw/timer: Remove unused "ui/console.h" header
>   hw/usb/dev-storage: Remove unused "ui/console.h" header
>   hw/i386/intel_iommu: Remove unused includes
>   hw/xen/xen_pt_load_rom: Remove unused includes
>   hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
>   hw/alpha/dp264: Include "net/net.h"
>   hw/hppa/machine: Include "net/net.h"
>   hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
>   hw/timer/hpet: Include "exec/address-spaces.h"
>   hw/pci-host/q35: Include "qemu/range.h"
>   hw/i2c/smbus_ich9: Include "qemu/range.h"
>   hw/pci-host/piix: Include "qemu/range.h"
>   hw/acpi: Include "hw/mem/nvdimm.h"
>   hw/i386: Include "hw/mem/nvdimm.h"
>   hw/pci-host/q35: Remove unused includes
>   hw/i386/pc: Clean up includes
> 
>  hw/acpi/cpu_hotplug.c             |  1 +
>  hw/acpi/ich9.c                    |  2 +-
>  hw/acpi/piix4.c                   |  1 +
>  hw/alpha/alpha_sys.h              |  1 -
>  hw/alpha/dp264.c                  |  1 +
>  hw/hppa/machine.c                 |  1 +
>  hw/i2c/smbus_ich9.c               |  1 +
>  hw/i386/acpi-build.c              |  1 +
>  hw/i386/pc.c                      |  1 +
>  hw/i386/pc_piix.c                 |  1 +
>  hw/i386/pc_q35.c                  |  1 +
>  hw/input/pckbd.c                  |  1 -
>  hw/isa/lpc_ich9.c                 |  2 --
>  hw/pci-host/piix.c                |  1 +
>  hw/pci-host/q35.c                 |  1 +
>  hw/timer/hpet.c                   |  2 +-
>  hw/timer/twl92230.c               |  1 -
>  hw/usb/dev-storage.c              |  1 -
>  hw/xen/xen_pt_load_rom.c          |  4 ----
>  include/hw/i386/ich9.h            |  1 -
>  include/hw/i386/intel_iommu.h     |  4 ----
>  include/hw/i386/ioapic_internal.h |  1 -
>  include/hw/i386/pc.h              | 12 +++---------
>  include/hw/pci-host/q35.h         |  8 +-------
>  vl.c                              |  1 +
>  25 files changed, 18 insertions(+), 34 deletions(-)
> 

Acked-by: John Snow <jsnow@redhat.com>
Philippe Mathieu-Daudé Oct. 26, 2019, 12:20 p.m. UTC | #2
Hi,

On 10/14/19 4:22 PM, Philippe Mathieu-Daudé wrote:
> This is a follow-up of Markus's cleanup series:
> Tame a few "touch this, recompile the world"
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg635748.html
> 
> This part is mostly restricted to X86, but since some file from the
> Alpha/PA-RISC machines include "hw/i386/pc.h" I had to fix them
> too.
> 
> Eventually I'll succeed at removing hw/i386/ dependency on non-X86
> platforms (Quest I started 2 years ago...).
> 
> Regards,
> 
> Phil.
> 
> Philippe Mathieu-Daudé (20):
>    vl: Add missing "hw/boards.h" include
>    hw/southbridge/ich9: Removed unused headers
>    hw/input/pckbd: Remove unused "hw/i386/pc.h" header
>    hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
>    hw/timer: Remove unused "ui/console.h" header
>    hw/usb/dev-storage: Remove unused "ui/console.h" header
>    hw/i386/intel_iommu: Remove unused includes
>    hw/xen/xen_pt_load_rom: Remove unused includes
>    hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
>    hw/alpha/dp264: Include "net/net.h"
>    hw/hppa/machine: Include "net/net.h"
>    hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
>    hw/timer/hpet: Include "exec/address-spaces.h"
>    hw/pci-host/q35: Include "qemu/range.h"
>    hw/i2c/smbus_ich9: Include "qemu/range.h"
>    hw/pci-host/piix: Include "qemu/range.h"
>    hw/acpi: Include "hw/mem/nvdimm.h"
>    hw/i386: Include "hw/mem/nvdimm.h"
>    hw/pci-host/q35: Remove unused includes
>    hw/i386/pc: Clean up includes
Laurent, since this series is fully reviewed, can it go via
your qemu-trivial tree?

Thanks,

Phil.
Laurent Vivier Oct. 26, 2019, 1:32 p.m. UTC | #3
Le 26/10/2019 à 14:20, Philippe Mathieu-Daudé a écrit :
> Hi,
> 
> On 10/14/19 4:22 PM, Philippe Mathieu-Daudé wrote:
>> This is a follow-up of Markus's cleanup series:
>> Tame a few "touch this, recompile the world"
>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg635748.html
>>
>> This part is mostly restricted to X86, but since some file from the
>> Alpha/PA-RISC machines include "hw/i386/pc.h" I had to fix them
>> too.
>>
>> Eventually I'll succeed at removing hw/i386/ dependency on non-X86
>> platforms (Quest I started 2 years ago...).
>>
>> Regards,
>>
>> Phil.
>>
>> Philippe Mathieu-Daudé (20):
>>    vl: Add missing "hw/boards.h" include
>>    hw/southbridge/ich9: Removed unused headers
>>    hw/input/pckbd: Remove unused "hw/i386/pc.h" header
>>    hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
>>    hw/timer: Remove unused "ui/console.h" header
>>    hw/usb/dev-storage: Remove unused "ui/console.h" header
>>    hw/i386/intel_iommu: Remove unused includes
>>    hw/xen/xen_pt_load_rom: Remove unused includes
>>    hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
>>    hw/alpha/dp264: Include "net/net.h"
>>    hw/hppa/machine: Include "net/net.h"
>>    hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
>>    hw/timer/hpet: Include "exec/address-spaces.h"
>>    hw/pci-host/q35: Include "qemu/range.h"
>>    hw/i2c/smbus_ich9: Include "qemu/range.h"
>>    hw/pci-host/piix: Include "qemu/range.h"
>>    hw/acpi: Include "hw/mem/nvdimm.h"
>>    hw/i386: Include "hw/mem/nvdimm.h"
>>    hw/pci-host/q35: Remove unused includes
>>    hw/i386/pc: Clean up includes
> Laurent, since this series is fully reviewed, can it go via
> your qemu-trivial tree?

I'll try but I'm not sure to have the time to do that before the softfreeze.

Thanks,
Laurent
Paolo Bonzini Feb. 27, 2020, 1:28 p.m. UTC | #4
On 26/10/19 15:32, Laurent Vivier wrote:
> Le 26/10/2019 à 14:20, Philippe Mathieu-Daudé a écrit :
>> Hi,
>>
>> On 10/14/19 4:22 PM, Philippe Mathieu-Daudé wrote:
>>> This is a follow-up of Markus's cleanup series:
>>> Tame a few "touch this, recompile the world"
>>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg635748.html
>>>
>>> This part is mostly restricted to X86, but since some file from the
>>> Alpha/PA-RISC machines include "hw/i386/pc.h" I had to fix them
>>> too.
>>>
>>> Eventually I'll succeed at removing hw/i386/ dependency on non-X86
>>> platforms (Quest I started 2 years ago...).
>>>
>>> Regards,
>>>
>>> Phil.
>>>
>>> Philippe Mathieu-Daudé (20):
>>>    vl: Add missing "hw/boards.h" include
>>>    hw/southbridge/ich9: Removed unused headers
>>>    hw/input/pckbd: Remove unused "hw/i386/pc.h" header
>>>    hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
>>>    hw/timer: Remove unused "ui/console.h" header
>>>    hw/usb/dev-storage: Remove unused "ui/console.h" header
>>>    hw/i386/intel_iommu: Remove unused includes
>>>    hw/xen/xen_pt_load_rom: Remove unused includes
>>>    hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
>>>    hw/alpha/dp264: Include "net/net.h"
>>>    hw/hppa/machine: Include "net/net.h"
>>>    hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
>>>    hw/timer/hpet: Include "exec/address-spaces.h"
>>>    hw/pci-host/q35: Include "qemu/range.h"
>>>    hw/i2c/smbus_ich9: Include "qemu/range.h"
>>>    hw/pci-host/piix: Include "qemu/range.h"
>>>    hw/acpi: Include "hw/mem/nvdimm.h"
>>>    hw/i386: Include "hw/mem/nvdimm.h"
>>>    hw/pci-host/q35: Remove unused includes
>>>    hw/i386/pc: Clean up includes
>> Laurent, since this series is fully reviewed, can it go via
>> your qemu-trivial tree?
> 
> I'll try but I'm not sure to have the time to do that before the softfreeze.

Ping :)

Paolo
Laurent Vivier March 9, 2020, 11:57 a.m. UTC | #5
Le 27/02/2020 à 14:28, Paolo Bonzini a écrit :
> On 26/10/19 15:32, Laurent Vivier wrote:
>> Le 26/10/2019 à 14:20, Philippe Mathieu-Daudé a écrit :
>>> Hi,
>>>
>>> On 10/14/19 4:22 PM, Philippe Mathieu-Daudé wrote:
>>>> This is a follow-up of Markus's cleanup series:
>>>> Tame a few "touch this, recompile the world"
>>>> https://www.mail-archive.com/qemu-devel@nongnu.org/msg635748.html
>>>>
>>>> This part is mostly restricted to X86, but since some file from the
>>>> Alpha/PA-RISC machines include "hw/i386/pc.h" I had to fix them
>>>> too.
>>>>
>>>> Eventually I'll succeed at removing hw/i386/ dependency on non-X86
>>>> platforms (Quest I started 2 years ago...).
>>>>
>>>> Regards,
>>>>
>>>> Phil.
>>>>
>>>> Philippe Mathieu-Daudé (20):
>>>>    vl: Add missing "hw/boards.h" include
>>>>    hw/southbridge/ich9: Removed unused headers
>>>>    hw/input/pckbd: Remove unused "hw/i386/pc.h" header
>>>>    hw/i386/ioapic_internal: Remove unused "hw/i386/ioapic.h" header
>>>>    hw/timer: Remove unused "ui/console.h" header
>>>>    hw/usb/dev-storage: Remove unused "ui/console.h" header
>>>>    hw/i386/intel_iommu: Remove unused includes
>>>>    hw/xen/xen_pt_load_rom: Remove unused includes
>>>>    hw/alpha/alpha_sys: Remove unused "hw/ide.h" header
>>>>    hw/alpha/dp264: Include "net/net.h"
>>>>    hw/hppa/machine: Include "net/net.h"
>>>>    hw/acpi/cpu_hotplug: Include "hw/pci/pci.h"
>>>>    hw/timer/hpet: Include "exec/address-spaces.h"
>>>>    hw/pci-host/q35: Include "qemu/range.h"
>>>>    hw/i2c/smbus_ich9: Include "qemu/range.h"
>>>>    hw/pci-host/piix: Include "qemu/range.h"
>>>>    hw/acpi: Include "hw/mem/nvdimm.h"
>>>>    hw/i386: Include "hw/mem/nvdimm.h"
>>>>    hw/pci-host/q35: Remove unused includes
>>>>    hw/i386/pc: Clean up includes
>>> Laurent, since this series is fully reviewed, can it go via
>>> your qemu-trivial tree?
>>
>> I'll try but I'm not sure to have the time to do that before the softfreeze.
> 
> Ping :)

Applied v2 to my trivial-patches branch.

Thanks,
Laurent