mbox series

[v2,0/3] Add support for Goodix GT917S touch controller

Message ID 20200227160802.7043-1-icenowy@aosc.io (mailing list archive)
Headers show
Series Add support for Goodix GT917S touch controller | expand

Message

Icenowy Zheng Feb. 27, 2020, 4:07 p.m. UTC
This patchset introduces support for Goodix GT917S touch controller.

The major difference with other touch controllers from Goodix is that
the ID string is no longer number-only (it contains a 'S'), so an
additional patch is introduced for migrating the ID to a string.

Icenowy Zheng (3):
  dt-bindings: input: touchscreen: add compatible string for Goodix
    GT917S
  Input: goodix - use string-based chip ID
  Input: goodix - Add support for Goodix GT917S

 .../bindings/input/touchscreen/goodix.yaml    |  1 +
 drivers/input/touchscreen/goodix.c            | 63 +++++++++++--------
 2 files changed, 38 insertions(+), 26 deletions(-)

Comments

Bastien Nocera Feb. 27, 2020, 5:51 p.m. UTC | #1
On Fri, 2020-02-28 at 00:07 +0800, Icenowy Zheng wrote:
> This patchset introduces support for Goodix GT917S touch controller.
> 
> The major difference with other touch controllers from Goodix is that
> the ID string is no longer number-only (it contains a 'S'), so an
> additional patch is introduced for migrating the ID to a string.
> 
> Icenowy Zheng (3):
>   dt-bindings: input: touchscreen: add compatible string for Goodix
>     GT917S
>   Input: goodix - use string-based chip ID

I'd put the dt-bindings patch after this change, but I don't think it
matters much in this case.

>   Input: goodix - Add support for Goodix GT917S

I didn't receive that last patch, whether on my address or the linux-
input@ list.

Cheers
Icenowy Zheng Feb. 28, 2020, 12:44 a.m. UTC | #2
于 2020年2月28日 GMT+08:00 上午1:51:54, Bastien Nocera <hadess@hadess.net> 写到:
>On Fri, 2020-02-28 at 00:07 +0800, Icenowy Zheng wrote:
>> This patchset introduces support for Goodix GT917S touch controller.
>> 
>> The major difference with other touch controllers from Goodix is that
>> the ID string is no longer number-only (it contains a 'S'), so an
>> additional patch is introduced for migrating the ID to a string.
>> 
>> Icenowy Zheng (3):
>>   dt-bindings: input: touchscreen: add compatible string for Goodix
>>     GT917S
>>   Input: goodix - use string-based chip ID
>
>I'd put the dt-bindings patch after this change, but I don't think it
>matters much in this case.
>
>>   Input: goodix - Add support for Goodix GT917S
>
>I didn't receive that last patch, whether on my address or the linux-
>input@ list.

My ISP works poorly recently and it's never sent.

I will sent v3 now including it.

>
>Cheers