| Message ID | 20200227070502.106762-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | e5096625bc6bd9e3a0d5f7f9d7ecebda0383c7f5 |
| Headers | show |
| Series | [-next] MIPS: pic32mzda: Drop pointless static qualifier | expand |
On Thu, Feb 27, 2020 at 07:05:02AM +0000, YueHaibing wrote: > There is no need to have the 'struct device_node *node' variable static > since new value always be assigned before use it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > arch/mips/pic32/pic32mzda/time.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to mips-next. Thomas.
diff --git a/arch/mips/pic32/pic32mzda/time.c b/arch/mips/pic32/pic32mzda/time.c index 754924f26089..7174e9abbb1b 100644 --- a/arch/mips/pic32/pic32mzda/time.c +++ b/arch/mips/pic32/pic32mzda/time.c @@ -23,7 +23,7 @@ static const struct of_device_id pic32_infra_match[] = { static unsigned int pic32_xlate_core_timer_irq(void) { - static struct device_node *node; + struct device_node *node; unsigned int irq; node = of_find_matching_node(NULL, pic32_infra_match);
There is no need to have the 'struct device_node *node' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- arch/mips/pic32/pic32mzda/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)