mbox series

[wireless,0/3] nl80211: add missing attribute validation

Message ID 20200303051058.4089398-1-kuba@kernel.org (mailing list archive)
Headers show
Series nl80211: add missing attribute validation | expand

Message

Jakub Kicinski March 3, 2020, 5:10 a.m. UTC
Hi!

Wireless seems to be missing a handful of netlink policy entries.

Compilation tested only.

Jakub Kicinski (3):
  nl80211: add missing attribute validation for critical protocol
    indication
  nl80211: add missing attribute validation for beacon report scanning
  nl80211: add missing attribute validation for channel switch

 net/wireless/nl80211.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Johannes Berg March 3, 2020, 7:29 a.m. UTC | #1
Hi Jakub,

> Wireless seems to be missing a handful of netlink policy entries.

Yep, these look good to me.

Here's a

Reviewed-by: Johannes Berg <johannes@sipsolutions.net>

if you want to apply them directly? I can take them, but you said later
you might want to pick them into stable, so maybe you have some more
direct plan there?

Thanks,
johannes
Jakub Kicinski March 3, 2020, 5:53 p.m. UTC | #2
On Tue, 03 Mar 2020 08:29:46 +0100 Johannes Berg wrote:
> Hi Jakub,
> 
> > Wireless seems to be missing a handful of netlink policy entries.  
> 
> Yep, these look good to me.
> 
> Here's a
> 
> Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> 
> if you want to apply them directly? 

Up to Dave, I only put a maintainer hat to cover for Dave when he's
away :)

> I can take them, but you said later you might want to pick them into
> stable, so maybe you have some more direct plan there?

No real plan, but the autoselection bot will very likely pick those up
even if we don't do anything, so given the very limited testing I was
cautious with refactoring.
Johannes Berg March 3, 2020, 6:58 p.m. UTC | #3
On Tue, 2020-03-03 at 09:53 -0800, Jakub Kicinski wrote:
> On Tue, 03 Mar 2020 08:29:46 +0100 Johannes Berg wrote:
> > Hi Jakub,
> > 
> > > Wireless seems to be missing a handful of netlink policy entries.  
> > 
> > Yep, these look good to me.
> > 
> > Here's a
> > 
> > Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
> > 
> > if you want to apply them directly? 
> 
> Up to Dave, I only put a maintainer hat to cover for Dave when he's
> away :)

Ah, ok; I'll just take them then, that's easier.

johannes