| Message ID | 20200305040704.10645-5-stanley.chu@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | scsi: ufs: some cleanups and make the delay for host enabling customizable | expand |
Hi Stanley, > > > MediaTek platform and UFS controller do not require the delay > for host enabling, thus remove it. > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > --- > drivers/scsi/ufs/ufs-mediatek.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > index 3b0e575d7460..ea3b5fd62492 100644 > --- a/drivers/scsi/ufs/ufs-mediatek.c > +++ b/drivers/scsi/ufs/ufs-mediatek.c > @@ -258,6 +258,8 @@ static int ufs_mtk_init(struct ufs_hba *hba) I would expect to set whatever is needed for your host controller In ufshcd_vops_hce_enable_notify(hba, PRE_CHANGE), and not here. Thanks, Avri > if (err) > goto out_variant_clear; > > + hba->hba_enable_delay_us = 0; > + > /* Enable runtime autosuspend */ > hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND; > > -- > 2.18.0
Hi Avri, On Thu, 2020-03-05 at 13:14 +0000, Avri Altman wrote: > Hi Stanley, > > > > > > > MediaTek platform and UFS controller do not require the delay > > for host enabling, thus remove it. > > > > Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> > > --- > > drivers/scsi/ufs/ufs-mediatek.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c > > index 3b0e575d7460..ea3b5fd62492 100644 > > --- a/drivers/scsi/ufs/ufs-mediatek.c > > +++ b/drivers/scsi/ufs/ufs-mediatek.c > > @@ -258,6 +258,8 @@ static int ufs_mtk_init(struct ufs_hba *hba) > I would expect to set whatever is needed for your host controller > In ufshcd_vops_hce_enable_notify(hba, PRE_CHANGE), and not here. > I think this is a good suggestion! And thus we could have more flexibility to customize the value according to different scenarios. I will consider this approach in next version. Thanks! Stanley Chu
diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c index 3b0e575d7460..ea3b5fd62492 100644 --- a/drivers/scsi/ufs/ufs-mediatek.c +++ b/drivers/scsi/ufs/ufs-mediatek.c @@ -258,6 +258,8 @@ static int ufs_mtk_init(struct ufs_hba *hba) if (err) goto out_variant_clear; + hba->hba_enable_delay_us = 0; + /* Enable runtime autosuspend */ hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND;
MediaTek platform and UFS controller do not require the delay for host enabling, thus remove it. Signed-off-by: Stanley Chu <stanley.chu@mediatek.com> --- drivers/scsi/ufs/ufs-mediatek.c | 2 ++ 1 file changed, 2 insertions(+)