| Message ID | 20200305103228.9686-2-zhang.lyra@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7ba87cfec71a21d195f08675a7e8603bf461ee32 |
| Headers | show |
| Series | [1/2] arm64: change ARCH_SPRD Kconfig to tristate | expand |
Hi Chunyan, On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > since we want them can be built-in when ARCH_SPRD is set as 'm'. Why would you want a serial driver for a specific platform to be builtin, while all other platform support is modular? > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > --- > drivers/tty/serial/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > index 52eaac21ff9f..2b9addc0afb5 100644 > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > config SERIAL_SPRD > tristate "Support for Spreadtrum serial" > - depends on ARCH_SPRD > select SERIAL_CORE > help > This enables the driver for the Spreadtrum's serial. Gr{oetje,eeting}s, Geert
Hi Geert, On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Chunyan, > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > Why would you want a serial driver for a specific platform to be builtin, > while all other platform support is modular? Oh, that's not this patch means. We just want serial driver can be builtin for any platform, so it should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) , otherwise if the config was set as 'm', the serial driver can't be selected as 'y' then. That's what I mean. Cheers, Chunyan > > > Signed-off-by: Chunyan Zhang <chunyan.zhang@unisoc.com> > > --- > > drivers/tty/serial/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig > > index 52eaac21ff9f..2b9addc0afb5 100644 > > --- a/drivers/tty/serial/Kconfig > > +++ b/drivers/tty/serial/Kconfig > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > config SERIAL_SPRD > > tristate "Support for Spreadtrum serial" > > - depends on ARCH_SPRD > > select SERIAL_CORE > > help > > This enables the driver for the Spreadtrum's serial. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Chunyan, On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > > > Why would you want a serial driver for a specific platform to be builtin, > > while all other platform support is modular? > > Oh, that's not this patch means. > > We just want serial driver can be builtin for any platform, so it What would be the benefit of the user to be able to have the SPRD serial driver built-in on any platform? AFAIU, it supports only Spreadtrum platforms. > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) > , otherwise if the config was set as 'm', the serial driver can't be > selected as 'y' then. I ask about that as a reply to PATCH 1/2. > That's what I mean. > > > --- a/drivers/tty/serial/Kconfig > > > +++ b/drivers/tty/serial/Kconfig > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > > > config SERIAL_SPRD > > > tristate "Support for Spreadtrum serial" > > > - depends on ARCH_SPRD > > > select SERIAL_CORE > > > help > > > This enables the driver for the Spreadtrum's serial. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On Mon, 9 Mar 2020 at 16:01, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Chunyan, > > On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > > > > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > > > > > Why would you want a serial driver for a specific platform to be builtin, > > > while all other platform support is modular? > > > > Oh, that's not this patch means. > > > > We just want serial driver can be builtin for any platform, so it > > What would be the benefit of the user to be able to have the SPRD serial > driver built-in on any platform? AFAIU, it supports only Spreadtrum > platforms. Right, it does support Spreadtrum platforms only indeed. Like I said on the replay to patch 1/2, simply because I want serial driver can be builtin all the time, no matter ARCH_SPRD is m or y. Regards, Chunyan > > > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) > > , otherwise if the config was set as 'm', the serial driver can't be > > selected as 'y' then. > > I ask about that as a reply to PATCH 1/2. > > > That's what I mean. > > > > > --- a/drivers/tty/serial/Kconfig > > > > +++ b/drivers/tty/serial/Kconfig > > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > > > > > config SERIAL_SPRD > > > > tristate "Support for Spreadtrum serial" > > > > - depends on ARCH_SPRD > > > > select SERIAL_CORE > > > > help > > > > This enables the driver for the Spreadtrum's serial. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Chunyan, On Mon, Mar 9, 2020 at 9:43 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > On Mon, 9 Mar 2020 at 16:01, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > > > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > > > > > > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > > > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > > > > > > > Why would you want a serial driver for a specific platform to be builtin, > > > > while all other platform support is modular? > > > > > > Oh, that's not this patch means. > > > > > > We just want serial driver can be builtin for any platform, so it > > > > What would be the benefit of the user to be able to have the SPRD serial > > driver built-in on any platform? AFAIU, it supports only Spreadtrum > > platforms. > > Right, it does support Spreadtrum platforms only indeed. > Like I said on the replay to patch 1/2, simply because I want serial > driver can be builtin all the time, no matter ARCH_SPRD is m or y. OK. So shouldn't the dependency become depends on ARCH_SPRD || ARCH_SPRD=m || COMPILE_TEST instead, to avoid asking the question when you're not building a kernel plus modules for Spreadtrum platforms? > > > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) > > > , otherwise if the config was set as 'm', the serial driver can't be > > > selected as 'y' then. > > > > I ask about that as a reply to PATCH 1/2. > > > > > That's what I mean. > > > > > > > --- a/drivers/tty/serial/Kconfig > > > > > +++ b/drivers/tty/serial/Kconfig > > > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > > > > > > > config SERIAL_SPRD > > > > > tristate "Support for Spreadtrum serial" > > > > > - depends on ARCH_SPRD > > > > > select SERIAL_CORE > > > > > help > > > > > This enables the driver for the Spreadtrum's serial. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Mon, 9 Mar 2020 at 18:32, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Chunyan, > > On Mon, Mar 9, 2020 at 9:43 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > On Mon, 9 Mar 2020 at 16:01, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > > > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > > > > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > > > > > > > > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > > > > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > > > > > > > > > Why would you want a serial driver for a specific platform to be builtin, > > > > > while all other platform support is modular? > > > > > > > > Oh, that's not this patch means. > > > > > > > > We just want serial driver can be builtin for any platform, so it > > > > > > What would be the benefit of the user to be able to have the SPRD serial > > > driver built-in on any platform? AFAIU, it supports only Spreadtrum > > > platforms. > > > > Right, it does support Spreadtrum platforms only indeed. > > Like I said on the replay to patch 1/2, simply because I want serial > > driver can be builtin all the time, no matter ARCH_SPRD is m or y. > > OK. > > So shouldn't the dependency become > > depends on ARCH_SPRD || ARCH_SPRD=m || COMPILE_TEST Oh, right, this's better than just removing dependency to ARCH_SPRD, but considering that this patch has been merged into Greg's tree, I will post another patch to add this. Thanks for your comments! Chunyan > > instead, to avoid asking the question when you're not building a kernel > plus modules for Spreadtrum platforms? > > > > > > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) > > > > , otherwise if the config was set as 'm', the serial driver can't be > > > > selected as 'y' then. > > > > > > I ask about that as a reply to PATCH 1/2. > > > > > > > That's what I mean. > > > > > > > > > --- a/drivers/tty/serial/Kconfig > > > > > > +++ b/drivers/tty/serial/Kconfig > > > > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > > > > > > > > > config SERIAL_SPRD > > > > > > tristate "Support for Spreadtrum serial" > > > > > > - depends on ARCH_SPRD > > > > > > select SERIAL_CORE > > > > > > help > > > > > > This enables the driver for the Spreadtrum's serial. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Geert, On Mon, Mar 9, 2020 at 4:01 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Chunyan, > > On Mon, Mar 9, 2020 at 2:18 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > On Fri, 6 Mar 2020 at 20:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > On Thu, Mar 5, 2020 at 11:33 AM Chunyan Zhang <zhang.lyra@gmail.com> wrote: > > > > From: Chunyan Zhang <chunyan.zhang@unisoc.com> > > > > > > > > Remove the dependency with ARCH_SPRD from sprd serial/console Kconfig-s, > > > > since we want them can be built-in when ARCH_SPRD is set as 'm'. > > > > > > Why would you want a serial driver for a specific platform to be builtin, > > > while all other platform support is modular? > > > > Oh, that's not this patch means. > > > > We just want serial driver can be builtin for any platform, so it > > What would be the benefit of the user to be able to have the SPRD serial > driver built-in on any platform? AFAIU, it supports only Spreadtrum > platforms. > Assume there is a all-in-one common kernel binary image say arm64 for all SoC platform and all device drivers are built as modules from different vendors for each specific devices. But for serial driver it is too late to be initialized as a module if users want to check early console log. At this circumstance vendors prefer to set their serial driver to be built into that all-in-one image as easy as to only set one config instead of enabling whole platform then disabling many out of serial. -Orson > > should not depend on a config which can be set as 'm' (i.e. ARCH_SPRD) > > , otherwise if the config was set as 'm', the serial driver can't be > > selected as 'y' then. > > I ask about that as a reply to PATCH 1/2. > > > That's what I mean. > > > > > --- a/drivers/tty/serial/Kconfig > > > > +++ b/drivers/tty/serial/Kconfig > > > > @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 > > > > > > > > config SERIAL_SPRD > > > > tristate "Support for Spreadtrum serial" > > > > - depends on ARCH_SPRD > > > > select SERIAL_CORE > > > > help > > > > This enables the driver for the Spreadtrum's serial. > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index 52eaac21ff9f..2b9addc0afb5 100644 --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -1452,7 +1452,6 @@ config SERIAL_MEN_Z135 config SERIAL_SPRD tristate "Support for Spreadtrum serial" - depends on ARCH_SPRD select SERIAL_CORE help This enables the driver for the Spreadtrum's serial.