| Message ID | 20200306150529.3370-2-alim.akhtar@samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | exynos-ufs: Add support for UFS HCI | expand |
On Fri, 6 Mar 2020 20:35:25 +0530, Alim Akhtar wrote: > This patch documents Samsung UFS PHY device tree bindings > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > --- > .../bindings/phy/samsung,ufs-phy.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > My bot found errors running 'make dt_binding_check' on your patch: Error: Documentation/devicetree/bindings/phy/samsung,ufs-phy.example.dts:23.36-37 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/phy/samsung,ufs-phy.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/phy/samsung,ufs-phy.example.dt.yaml] Error 1 Makefile:1262: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1250378 Please check and re-submit.
Hi Rob, > -----Original Message----- > From: Rob Herring <robh@kernel.org> > Sent: 09 March 2020 23:41 > To: Alim Akhtar <alim.akhtar@samsung.com> > Cc: robh+dt@kernel.org; devicetree@vger.kernel.org; linux- > scsi@vger.kernel.org; krzk@kernel.org; avri.altman@wdc.com; > martin.petersen@oracle.com; kwmad.kim@samsung.com; > stanley.chu@mediatek.com; cang@codeaurora.org; Alim Akhtar > <alim.akhtar@samsung.com> > Subject: Re: [PATCH 1/5] dt-bindings: phy: Document Samsung UFS PHY bindings > > On Fri, 6 Mar 2020 20:35:25 +0530, Alim Akhtar wrote: > > This patch documents Samsung UFS PHY device tree bindings > > > > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> > > --- > > .../bindings/phy/samsung,ufs-phy.yaml | 60 +++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > Error: Documentation/devicetree/bindings/phy/samsung,ufs- > phy.example.dts:23.36-37 syntax error FATAL ERROR: Unable to parse input tree > scripts/Makefile.lib:311: recipe for target > 'Documentation/devicetree/bindings/phy/samsung,ufs-phy.example.dt.yaml' > failed > make[1]: *** [Documentation/devicetree/bindings/phy/samsung,ufs- > phy.example.dt.yaml] Error 1 > Makefile:1262: recipe for target 'dt_binding_check' failed > make: *** [dt_binding_check] Error 2 > > See https://protect2.fireeye.com/url?k=872f213d-dafc7db2-872eaa72- > 0cc47a31ce52- > 327f14918e272963&u=https://patchwork.ozlabs.org/patch/1250378 > Please check and re-submit. Sure will run "'make dt_binding_check" and fix this, just waiting for some more review comments on other patches in this series. Thanks for feedback. Regards, Alim
diff --git a/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml new file mode 100644 index 000000000000..6e204ea5c8ff --- /dev/null +++ b/Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml @@ -0,0 +1,60 @@ +# SPDX-License-Identifier: (GPL-2.0) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/samsung,ufs-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SoC series UFS PHY Device Tree Bindings + +maintainers: + - Alim Akhtar <alim.akhtar@samsung.com> + +properties: + "#phy-cells": + const: 0 + + compatible: + enum: + - samsung,exynos7-ufs-phy + + reg: + items: + - description: PHY base register address + + reg-names: + items: + - const: phy-pma + + clocks: + items: + - description: PLL reference clock + - description: Referencec clock parrent + + clock-names: + items: + - const: ref_clk + - const: ref_clk_parent + +required: + - "#phy-cells" + - compatible + - reg + - reg-names + - clocks + - clock-names + +examples: + - | + ufs_phy: ufs-phy@0x15571800 { + compatible = "samsung,exynos7-ufs-phy"; + reg = <0x15571800 0x240>; + reg-names = "phy-pma"; + samsung,pmu-syscon = <&pmu_system_controller>; + #phy-cells = <0>; + clocks = <&clock_fsys1 MOUT_FSYS1_PHYCLK_SEL1>, + <&clock_top1 CLK_SCLK_PHY_FSYS1_26M>; + clock-names = "ref_clk_parent", + "ref_clk"; + }; + +...
This patch documents Samsung UFS PHY device tree bindings Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com> --- .../bindings/phy/samsung,ufs-phy.yaml | 60 +++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/samsung,ufs-phy.yaml