| Message ID | 1583839084-31579-1-git-send-email-liweihang@huawei.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RDMA/hns: Refactor wqe related codes | expand |
Hi Jason, Sorry, I didn't notice that the first three patches of this series had been applied to you for-next branch, so I sent this new version. Need I resend the last two patches in a new series? Thanks Weihang On 2020/3/10 19:22, Weihang Li wrote: > Process of wqe is hard to understand and maintain in hns, this series > refactor wqe related code, especially in hns_roce_v2_post_send(). > > Previous discussion could be found at: > - v2: https://patchwork.kernel.org/cover/11422963/ > - v1: https://patchwork.kernel.org/cover/11415395/ > > Changes since v2: > - Remove a redundant assignment of "NULL" in patch 4/5. > > Changes since v1: > - Fix comments from Leon about the inplementation of to_hr_opcode() in > patch 3/5. > - Patch 4/5 couldn't be applied. Just do a rebase. > > Xi Wang (5): > RDMA/hns: Rename wqe buffer related functions > RDMA/hns: Optimize wqe buffer filling process for post send > RDMA/hns: Optimize the wr opcode conversion from ib to hns > RDMA/hns: Optimize base address table config flow for qp buffer > RDMA/hns: Optimize wqe buffer set flow for post send > > drivers/infiniband/hw/hns/hns_roce_device.h | 10 +- > drivers/infiniband/hw/hns/hns_roce_hem.c | 16 +- > drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 9 +- > drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 588 ++++++++++++++-------------- > drivers/infiniband/hw/hns/hns_roce_qp.c | 48 +-- > 5 files changed, 319 insertions(+), 352 deletions(-) >
On Tue, Mar 10, 2020 at 08:53:22PM +0800, Weihang Li wrote: > Hi Jason, > > Sorry, I didn't notice that the first three patches of this series had > been applied to you for-next branch, so I sent this new version. Need > I resend the last two patches in a new series? Oh, something got out of sorts, I did not intend to push those four patches, I will drop them an this v3 will supersede and the 'minimum depth of qp to 0' should be resent with comments addressed. Jason
On 2020/3/10 22:42, Jason Gunthorpe wrote: > On Tue, Mar 10, 2020 at 08:53:22PM +0800, Weihang Li wrote: >> Hi Jason, >> >> Sorry, I didn't notice that the first three patches of this series had >> been applied to you for-next branch, so I sent this new version. Need >> I resend the last two patches in a new series? > > Oh, something got out of sorts, I did not intend to push those four > patches, I will drop them an this v3 will supersede and the 'minimum > depth of qp to 0' should be resent with comments addressed. > > Jason > OK, thank you :) Weihang
On Tue, Mar 10, 2020 at 07:17:59PM +0800, Weihang Li wrote: > Process of wqe is hard to understand and maintain in hns, this series > refactor wqe related code, especially in hns_roce_v2_post_send(). > > Previous discussion could be found at: > - v2: https://patchwork.kernel.org/cover/11422963/ > - v1: https://patchwork.kernel.org/cover/11415395/ > > Changes since v2: > - Remove a redundant assignment of "NULL" in patch 4/5. > > Changes since v1: > - Fix comments from Leon about the inplementation of to_hr_opcode() in > patch 3/5. > - Patch 4/5 couldn't be applied. Just do a rebase. > > Xi Wang (5): > RDMA/hns: Rename wqe buffer related functions > RDMA/hns: Optimize wqe buffer filling process for post send > RDMA/hns: Optimize the wr opcode conversion from ib to hns > RDMA/hns: Optimize base address table config flow for qp buffer > RDMA/hns: Optimize wqe buffer set flow for post send Applied to for-next, thanks Jason