| Message ID | 20200309213940.27965-1-manasi.d.navare@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v5,1/2] drm/edid: Name the detailed monitor range flags | expand |
On Mon, Mar 09, 2020 at 02:39:39PM -0700, Manasi Navare wrote: > This patch adds defines for the detailed monitor > range flags as per the EDID specification. > > v2: > * Rename the flags with DRM_EDID_ (Jani N) > > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Harry Wentland <harry.wentland@amd.com> > Cc: Clinton A Taylor <clinton.a.taylor@intel.com> > Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> > Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> > --- > include/drm/drm_edid.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > index f0b03d401c27..34b15e3d070c 100644 > --- a/include/drm/drm_edid.h > +++ b/include/drm/drm_edid.h > @@ -91,6 +91,11 @@ struct detailed_data_string { > u8 str[13]; > } __attribute__((packed)); > > +#define DRM_EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 > +#define DRM_EDID_RANGE_LIMITS_ONLY_FLAG 0x01 > +#define DRM_EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 > +#define DRM_EDID_CVT_SUPPORT_FLAG 0x04 No indication what flags thse are. Also missing the actual change to use them in drm_edid.c. > + > struct detailed_data_monitor_range { > u8 min_vfreq; > u8 max_vfreq; > -- > 2.19.1
On Tue, Mar 10, 2020 at 06:20:27PM +0200, Ville Syrjälä wrote: > On Mon, Mar 09, 2020 at 02:39:39PM -0700, Manasi Navare wrote: > > This patch adds defines for the detailed monitor > > range flags as per the EDID specification. > > > > v2: > > * Rename the flags with DRM_EDID_ (Jani N) > > > > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Cc: Harry Wentland <harry.wentland@amd.com> > > Cc: Clinton A Taylor <clinton.a.taylor@intel.com> > > Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com> > > Cc: Jani Nikula <jani.nikula@linux.intel.com> > > Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> > > Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com> > > --- > > include/drm/drm_edid.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h > > index f0b03d401c27..34b15e3d070c 100644 > > --- a/include/drm/drm_edid.h > > +++ b/include/drm/drm_edid.h > > @@ -91,6 +91,11 @@ struct detailed_data_string { > > u8 str[13]; > > } __attribute__((packed)); > > > > +#define DRM_EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 > > +#define DRM_EDID_RANGE_LIMITS_ONLY_FLAG 0x01 > > +#define DRM_EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 > > +#define DRM_EDID_CVT_SUPPORT_FLAG 0x04 > > No indication what flags thse are. Also missing the > actual change to use them in drm_edid.c. > The name of the flag in #define indicates what flag it is, how else do you want me to add teh indication? I have done the change in my second patch to use this flag #define Use of these flags in other places in drm_edid.c will be follow up patches SOunds good? Manasi > > + > > struct detailed_data_monitor_range { > > u8 min_vfreq; > > u8 max_vfreq; > > -- > > 2.19.1 > > -- > Ville Syrjälä > Intel
diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h index f0b03d401c27..34b15e3d070c 100644 --- a/include/drm/drm_edid.h +++ b/include/drm/drm_edid.h @@ -91,6 +91,11 @@ struct detailed_data_string { u8 str[13]; } __attribute__((packed)); +#define DRM_EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00 +#define DRM_EDID_RANGE_LIMITS_ONLY_FLAG 0x01 +#define DRM_EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02 +#define DRM_EDID_CVT_SUPPORT_FLAG 0x04 + struct detailed_data_monitor_range { u8 min_vfreq; u8 max_vfreq;