| Message ID | 20200227110246.8624-1-m.felsch@pengutronix.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 636b45b8efa91db05553840b6c0120d6fa6b94fa |
| Headers | show |
| Series | [v4] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage | expand |
On Thu, Feb 27, 2020 at 12:02:46PM +0100, Marco Felsch wrote: > The current set minimum voltage of 730000µV seems to be wrong. I don't > know the document which specifies that but the imx6qdl datasheets says > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). Stefan, Any comment on this change? Shawn > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> > --- > v4: > - rebased ontop of v5.6-rc1 > v3: > - fix commit message > v2: > - use ldo bypassed values > > arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > index 4d18952658f8..77d871340eb7 100644 > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > @@ -112,7 +112,7 @@ > regulators { > vdd_arm: buck1 { > regulator-name = "vdd_arm"; > - regulator-min-microvolt = <730000>; > + regulator-min-microvolt = <925000>; > regulator-max-microvolt = <1380000>; > regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>; > regulator-always-on; > @@ -120,7 +120,7 @@ > > vdd_soc: buck2 { > regulator-name = "vdd_soc"; > - regulator-min-microvolt = <730000>; > + regulator-min-microvolt = <1150000>; > regulator-max-microvolt = <1380000>; > regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>; > regulator-always-on; > -- > 2.20.1 >
Hi Shawn, On 11.03.20 08:33, Shawn Guo wrote: > On Thu, Feb 27, 2020 at 12:02:46PM +0100, Marco Felsch wrote: >> The current set minimum voltage of 730000µV seems to be wrong. I don't >> know the document which specifies that but the imx6qdl datasheets says >> that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, >> lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). > > Stefan, > > Any comment on this change? looks good to me. Thanks for asking. Reviewed-by: Stefan Riedmueller <s.riedmueller@phytec.de> Regards, Stefan > > Shawn > >> >> Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") >> Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> >> --- >> v4: >> - rebased ontop of v5.6-rc1 >> v3: >> - fix commit message >> v2: >> - use ldo bypassed values >> >> arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi >> index 4d18952658f8..77d871340eb7 100644 >> --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi >> +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi >> @@ -112,7 +112,7 @@ >> regulators { >> vdd_arm: buck1 { >> regulator-name = "vdd_arm"; >> - regulator-min-microvolt = <730000>; >> + regulator-min-microvolt = <925000>; >> regulator-max-microvolt = <1380000>; >> regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>; >> regulator-always-on; >> @@ -120,7 +120,7 @@ >> >> vdd_soc: buck2 { >> regulator-name = "vdd_soc"; >> - regulator-min-microvolt = <730000>; >> + regulator-min-microvolt = <1150000>; >> regulator-max-microvolt = <1380000>; >> regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>; >> regulator-always-on; >> -- >> 2.20.1 >>
On Thu, Feb 27, 2020 at 12:02:46PM +0100, Marco Felsch wrote: > The current set minimum voltage of 730000µV seems to be wrong. I don't > know the document which specifies that but the imx6qdl datasheets says > that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, > lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") > Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> Applied, thanks.
diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi index 4d18952658f8..77d871340eb7 100644 --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi @@ -112,7 +112,7 @@ regulators { vdd_arm: buck1 { regulator-name = "vdd_arm"; - regulator-min-microvolt = <730000>; + regulator-min-microvolt = <925000>; regulator-max-microvolt = <1380000>; regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>; regulator-always-on; @@ -120,7 +120,7 @@ vdd_soc: buck2 { regulator-name = "vdd_soc"; - regulator-min-microvolt = <730000>; + regulator-min-microvolt = <1150000>; regulator-max-microvolt = <1380000>; regulator-initial-mode = <DA9063_BUCK_MODE_SYNC>; regulator-always-on;
The current set minimum voltage of 730000µV seems to be wrong. I don't know the document which specifies that but the imx6qdl datasheets says that the minimum voltage should be 0.925V for VDD_ARM (LDO bypassed, lowest opp) and 1.15V for VDD_SOC (LDO bypassed, lowest opp). Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCORE-i.MX 6 SOM") Signed-off-by: Marco Felsch <m.felsch@pengutronix.de> --- v4: - rebased ontop of v5.6-rc1 v3: - fix commit message v2: - use ldo bypassed values arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)