mbox series

[RFC,0/3] perf/imx_ddr: Add system PMU support

Message ID 20200226073433.5834-1-qiangqing.zhang@nxp.com (mailing list archive)
Headers show
Series perf/imx_ddr: Add system PMU support | expand

Message

Joakim Zhang Feb. 26, 2020, 7:34 a.m. UTC
Hi John,

The sysfs location for userspace to get the PMU identifier has chenged a
bit, this could be more formal.
	/sys/bus/event_source/devices/<PMU DEVICE>/identifier
Small update shoud be done from userspace :-)

Hi Will, Mark,

As we discussed before, this patch set intends to expose system PMU
identifier for userspace. Anyone wants to support system PMU must expose
this "identifier" property, since John will always read this file to get
system PMU's identifier.

Any comments?

Regards,
Joakim

Joakim Zhang (3):
  perf/imx_ddr: Add system PMU identifier for userspace
  bindings/perf/imx-ddr: update compatible string
  arch: arm64: imx8mq/m/n: remove unused compatible string

 .../devicetree/bindings/perf/fsl-imx-ddr.txt  |  4 +-
 arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  2 +-
 arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  2 +-
 arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  2 +-
 drivers/perf/fsl_imx8_ddr_perf.c              | 45 +++++++++++++++++--
 5 files changed, 48 insertions(+), 7 deletions(-)

Comments

Joakim Zhang March 11, 2020, 8:52 a.m. UTC | #1
Kindly Ping...

Best Regards,
Joakim Zhang

> -----Original Message-----
> From: Joakim Zhang <qiangqing.zhang@nxp.com>
> Sent: 2020年2月26日 15:35
> To: john.garry@huawei.com; will@kernel.org; mark.rutland@arm.com
> Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org
> Subject: [PATCH RFC 0/3] perf/imx_ddr: Add system PMU support
> 
> Hi John,
> 
> The sysfs location for userspace to get the PMU identifier has chenged a bit,
> this could be more formal.
> 	/sys/bus/event_source/devices/<PMU DEVICE>/identifier Small update
> shoud be done from userspace :-)
> 
> Hi Will, Mark,
> 
> As we discussed before, this patch set intends to expose system PMU identifier
> for userspace. Anyone wants to support system PMU must expose this
> "identifier" property, since John will always read this file to get system PMU's
> identifier.
> 
> Any comments?
> 
> Regards,
> Joakim
> 
> Joakim Zhang (3):
>   perf/imx_ddr: Add system PMU identifier for userspace
>   bindings/perf/imx-ddr: update compatible string
>   arch: arm64: imx8mq/m/n: remove unused compatible string
> 
>  .../devicetree/bindings/perf/fsl-imx-ddr.txt  |  4 +-
>  arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  2 +-
>  arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  2 +-
>  arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  2 +-
>  drivers/perf/fsl_imx8_ddr_perf.c              | 45 +++++++++++++++++--
>  5 files changed, 48 insertions(+), 7 deletions(-)
> 
> --
> 2.17.1
John Garry March 11, 2020, 9:46 a.m. UTC | #2
On 11/03/2020 08:52, Joakim Zhang wrote:
> 
> Kindly Ping...
> 
> Best Regards,
> Joakim Zhang
> 
>> -----Original Message-----
>> From: Joakim Zhang <qiangqing.zhang@nxp.com>
>> Sent: 2020年2月26日 15:35
>> To: john.garry@huawei.com; will@kernel.org; mark.rutland@arm.com
>> Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org
>> Subject: [PATCH RFC 0/3] perf/imx_ddr: Add system PMU support
>>
>> Hi John,
>>
>> The sysfs location for userspace to get the PMU identifier has chenged a bit,
>> this could be more formal.
>> 	/sys/bus/event_source/devices/<PMU DEVICE>/identifier Small update
>> shoud be done from userspace :-)

To me, that looks ok. Maybe Mark or Will would like the file 
renamed/relocated.

And I already gave a comment on " [PATCH RFC 2/3] bindings/perf/imx-ddr: 
update compatible string"

Thanks,
John

>>
>> Hi Will, Mark,
>>
>> As we discussed before, this patch set intends to expose system PMU identifier
>> for userspace. Anyone wants to support system PMU must expose this
>> "identifier" property, since John will always read this file to get system PMU's
>> identifier.
>>
>> Any comments?
>>
>> Regards,
>> Joakim
>>
>> Joakim Zhang (3):
>>    perf/imx_ddr: Add system PMU identifier for userspace
>>    bindings/perf/imx-ddr: update compatible string
>>    arch: arm64: imx8mq/m/n: remove unused compatible string
>>
>>   .../devicetree/bindings/perf/fsl-imx-ddr.txt  |  4 +-
>>   arch/arm64/boot/dts/freescale/imx8mm.dtsi     |  2 +-
>>   arch/arm64/boot/dts/freescale/imx8mn.dtsi     |  2 +-
>>   arch/arm64/boot/dts/freescale/imx8mq.dtsi     |  2 +-
>>   drivers/perf/fsl_imx8_ddr_perf.c              | 45 +++++++++++++++++--
>>   5 files changed, 48 insertions(+), 7 deletions(-)
>>
>> --
>> 2.17.1
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>