| Message ID | 20200307134841.13803-1-jbx6244@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,1/5] ARM: dts: rockchip: fix vqmmc-supply property name for rk3188-bqedison2qc | expand |
Am Samstag, 7. März 2020, 14:48:37 CET schrieb Johan Jonker: > A test with the command below does not detect all errors > in combination with 'additionalProperties: false' and > allOf: > - $ref: "synopsys-dw-mshc-common.yaml#" > allOf: > - $ref: "mmc-controller.yaml#" > > 'additionalProperties' applies to all properties that are not > accounted-for by 'properties' or 'patternProperties' in > the immediate schema. > > First when we combine rockchip-dw-mshc.yaml, > synopsys-dw-mshc-common.yaml and mmc-controller.yaml it gives > this error: > > arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: mmc@10218000: > 'vmmcq-supply' does not match any of the regexes: > '^.*@[0-9]+$', > '^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)| > uhs-(sdr(12|25|50|104)|ddr50))$', > 'pinctrl-[0-9]+' > > 'vmmcq-supply' is not a valid property name for mmc nodes. > Fix this error by renaming it to 'vqmmc-supply'. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> applied all 5 for 5.7 Thanks Heiko
diff --git a/arch/arm/boot/dts/rk3188-bqedison2qc.dts b/arch/arm/boot/dts/rk3188-bqedison2qc.dts index ad1afd403..8afb2fd5d 100644 --- a/arch/arm/boot/dts/rk3188-bqedison2qc.dts +++ b/arch/arm/boot/dts/rk3188-bqedison2qc.dts @@ -465,7 +465,7 @@ non-removable; pinctrl-names = "default"; pinctrl-0 = <&sd1_clk>, <&sd1_cmd>, <&sd1_bus4>; - vmmcq-supply = <&vccio_wl>; + vqmmc-supply = <&vccio_wl>; #address-cells = <1>; #size-cells = <0>; status = "okay";
A test with the command below does not detect all errors in combination with 'additionalProperties: false' and allOf: - $ref: "synopsys-dw-mshc-common.yaml#" allOf: - $ref: "mmc-controller.yaml#" 'additionalProperties' applies to all properties that are not accounted-for by 'properties' or 'patternProperties' in the immediate schema. First when we combine rockchip-dw-mshc.yaml, synopsys-dw-mshc-common.yaml and mmc-controller.yaml it gives this error: arch/arm/boot/dts/rk3188-bqedison2qc.dt.yaml: mmc@10218000: 'vmmcq-supply' does not match any of the regexes: '^.*@[0-9]+$', '^clk-phase-(legacy|sd-hs|mmc-(hs|hs[24]00|ddr52)| uhs-(sdr(12|25|50|104)|ddr50))$', 'pinctrl-[0-9]+' 'vmmcq-supply' is not a valid property name for mmc nodes. Fix this error by renaming it to 'vqmmc-supply'. make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.yaml Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- arch/arm/boot/dts/rk3188-bqedison2qc.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)