| Message ID | 20200226073433.5834-3-qiangqing.zhang@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | perf/imx_ddr: Add system PMU support | expand |
On 26/02/2020 07:34, Joakim Zhang wrote: > Update compatible string according to driver change.` > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > --- > Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > index 7822a806ea0a..b27a1d4fec78 100644 > --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > @@ -4,7 +4,9 @@ Required properties: > > - compatible: should be one of: > "fsl,imx8-ddr-pmu" > - "fsl,imx8m-ddr-pmu" > + "fsl,imx8mq-ddr-pmu" > + "fsl,imx8mm-ddr-pmu" > + "fsl,imx8mn-ddr-pmu" > "fsl,imx8mp-ddr-pmu" > You need to ensure that you're not loosing backwards compatibility such that old firmware still works with a new kernel. I see that the dts files use the generic "fsl,imx8m-ddr-pmu" and the per-Soc string as well, so looks ok, but I don't know about DT files out of mainline... Thanks, John > - reg: physical address and size >
> -----Original Message----- > From: John Garry <john.garry@huawei.com> > Sent: 2020年3月3日 20:04 > To: Joakim Zhang <qiangqing.zhang@nxp.com>; will@kernel.org; > mark.rutland@arm.com > Cc: dl-linux-imx <linux-imx@nxp.com>; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH RFC 2/3] bindings/perf/imx-ddr: update compatible string > > On 26/02/2020 07:34, Joakim Zhang wrote: > > Update compatible string according to driver change.` > > > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> > > --- > > Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > index 7822a806ea0a..b27a1d4fec78 100644 > > --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt > > @@ -4,7 +4,9 @@ Required properties: > > > > - compatible: should be one of: > > "fsl,imx8-ddr-pmu" > > - "fsl,imx8m-ddr-pmu" > > + "fsl,imx8mq-ddr-pmu" > > + "fsl,imx8mm-ddr-pmu" > > + "fsl,imx8mn-ddr-pmu" > > "fsl,imx8mp-ddr-pmu" > > > > You need to ensure that you're not loosing backwards compatibility such that > old firmware still works with a new kernel. > > I see that the dts files use the generic "fsl,imx8m-ddr-pmu" and the per-Soc > string as well, so looks ok, but I don't know about DT files out of mainline... This was ignored, sorry for that. This change is in .dtsi file, per soc only have one, so it's safe for .dts out of mainline. Or retain "fsl,imx8m-ddr-pmu" as a backwards compatibility without identifier setting? It's may be unnecessary. Best Regards, Joakim Zhang > Thanks, > John > > > - reg: physical address and size > >
diff --git a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt index 7822a806ea0a..b27a1d4fec78 100644 --- a/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt +++ b/Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt @@ -4,7 +4,9 @@ Required properties: - compatible: should be one of: "fsl,imx8-ddr-pmu" - "fsl,imx8m-ddr-pmu" + "fsl,imx8mq-ddr-pmu" + "fsl,imx8mm-ddr-pmu" + "fsl,imx8mn-ddr-pmu" "fsl,imx8mp-ddr-pmu" - reg: physical address and size
Update compatible string according to driver change.` Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> --- Documentation/devicetree/bindings/perf/fsl-imx-ddr.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)