| Message ID | 20200311112921.29031-1-beanhuo@micron.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Revert "scsi: ufs: Let the SCSI core allocate per-command UFS data" | expand |
Hi, > > From: Bean Huo <beanhuo@micron.com> > > Hi, Martin > > Based on Bart's feedack, the less risky way is to revert commit: > > 34656dda81ac "scsi: ufs: Let the SCSI core allocate per-command UFS data" > > Bean Huo (1): > Revert "scsi: ufs: Let the SCSI core allocate per-command UFS data" Maybe it's safer to revert the entire series? Thanks, Avri > > drivers/scsi/ufs/ufshcd.c | 198 ++++++++++++++------------------------ > drivers/scsi/ufs/ufshcd.h | 5 + > 2 files changed, 75 insertions(+), 128 deletions(-) > > -- > 2.17.1
Hi, Avri
Do you want to revert all or two (scsi: ufs: Let the SCSI core allocate per-command UFS data, scsi: core: Introduce {init,exit}_cmd_priv() )?
Because the patches "scsi: ufs: Simplify two tests" and "scsi: ufs: Introduce ufshcd_init_lrb()" are ok to me.
No problem keeping them. Just this one "scsi: core: Introduce {init,exit}_cmd_priv()" is not necessary, since no drivers it now.
//Bean
>
> Hi,
>
> >
> > From: Bean Huo <beanhuo@micron.com>
> >
> > Hi, Martin
> >
> > Based on Bart's feedack, the less risky way is to revert commit:
> >
> > 34656dda81ac "scsi: ufs: Let the SCSI core allocate per-command UFS data"
> >
> > Bean Huo (1):
> > Revert "scsi: ufs: Let the SCSI core allocate per-command UFS data"
> Maybe it's safer to revert the entire series?
>
> Thanks,
> Avri
>
>
> >
> > drivers/scsi/ufs/ufshcd.c | 198 ++++++++++++++------------------------
> > drivers/scsi/ufs/ufshcd.h | 5 +
> > 2 files changed, 75 insertions(+), 128 deletions(-)
> >
> > --
> > 2.17.1
On 3/11/20 5:53 AM, Bean Huo (beanhuo) wrote: > Hi, Avri > Do you want to revert all or two (scsi: ufs: Let the SCSI core allocate per-command UFS data, scsi: core: Introduce {init,exit}_cmd_priv() )? > Because the patches "scsi: ufs: Simplify two tests" and "scsi: ufs: Introduce ufshcd_init_lrb()" are ok to me. > No problem keeping them. Just this one "scsi: core: Introduce {init,exit}_cmd_priv()" is not necessary, since no drivers it now. I agree with Bean. The other patches from the same series are small and easy to review. The SCSI core patch has been tested with other SCSI LLDs. Bart.
From: Bean Huo <beanhuo@micron.com> Hi, Martin Based on Bart's feedack, the less risky way is to revert commit: 34656dda81ac "scsi: ufs: Let the SCSI core allocate per-command UFS data" Bean Huo (1): Revert "scsi: ufs: Let the SCSI core allocate per-command UFS data" drivers/scsi/ufs/ufshcd.c | 198 ++++++++++++++------------------------ drivers/scsi/ufs/ufshcd.h | 5 + 2 files changed, 75 insertions(+), 128 deletions(-)