| Message ID | 20200310134603.30260-2-robert.foss@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | media: ov8856: Add sensor modes & devicetree support | expand |
Hi Robert, On Tue, Mar 10, 2020 at 10:46 AM Robert Foss <robert.foss@linaro.org> wrote: > + ov8856: camera-sensor@10 { > + compatible = "ovti,ov8856"; > + reg = <0x10>; > + reset-gpios = <&pio 111 GPIO_ACTIVE_HIGH>; Could you double check this is correct? Other OmniVision sensors have reset-gpios as active low. I suspect that the driver has also an inverted logic, so that's why it works. I don't have access to the datasheet though, so I am just guessing.
Hey Fabio, Thanks for having a look at this series so quickly. On Tue, 10 Mar 2020 at 14:57, Fabio Estevam <festevam@gmail.com> wrote: > > Hi Robert, > > On Tue, Mar 10, 2020 at 10:46 AM Robert Foss <robert.foss@linaro.org> wrote: > > > + ov8856: camera-sensor@10 { > > + compatible = "ovti,ov8856"; > > + reg = <0x10>; > > + reset-gpios = <&pio 111 GPIO_ACTIVE_HIGH>; > > Could you double check this is correct? Other OmniVision sensors have > reset-gpios as active low. I have tested this, unfortunately I don't have access to a ov8856 datasheet that includes this level of detail. But I have tested this. > > I suspect that the driver has also an inverted logic, so that's why it works. That could explain it still working. Let me have a look into the driver and see what it does. > > I don't have access to the datasheet though, so I am just guessing. Me neither unfortunately, if anyone does have a link for it, I would very much appreciate it.
On Tue, 10 Mar 2020 14:46:01 +0100, Robert Foss wrote: > From: Dongchun Zhu <dongchun.zhu@mediatek.com> > > This patch adds documentation of device tree in YAML schema for the > OV8856 CMOS image sensor. > > Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com> > Signed-off-by: Robert Foss <robert.foss@linaro.org> > --- > > - Changes since v3: > * robher: Fix syntax error > * robher: Removed maxItems > * Fixes yaml 'make dt-binding-check' errors > > - Changes since v2: > Fixes comments from from Andy, Tomasz, Sakari, Rob. > * Convert text documentation to YAML schema. > > - Changes since v1: > Fixes comments from Sakari, Tomasz > * Add clock-frequency and link-frequencies in DT > > .../devicetree/bindings/media/i2c/ov8856.yaml | 129 ++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 130 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov8856.yaml > My bot found errors running 'make dt_binding_check' on your patch: Error: Documentation/devicetree/bindings/media/i2c/ov8856.example.dts:26.28-29 syntax error FATAL ERROR: Unable to parse input tree scripts/Makefile.lib:311: recipe for target 'Documentation/devicetree/bindings/media/i2c/ov8856.example.dt.yaml' failed make[1]: *** [Documentation/devicetree/bindings/media/i2c/ov8856.example.dt.yaml] Error 1 Makefile:1262: recipe for target 'dt_binding_check' failed make: *** [dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1252173 Please check and re-submit.
On Tue, 10 Mar 2020 at 16:51, Robert Foss <robert.foss@linaro.org> wrote: > > Hey Fabio, > > Thanks for having a look at this series so quickly. > > On Tue, 10 Mar 2020 at 14:57, Fabio Estevam <festevam@gmail.com> wrote: > > > > Hi Robert, > > > > On Tue, Mar 10, 2020 at 10:46 AM Robert Foss <robert.foss@linaro.org> wrote: > > > > > + ov8856: camera-sensor@10 { > > > + compatible = "ovti,ov8856"; > > > + reg = <0x10>; > > > + reset-gpios = <&pio 111 GPIO_ACTIVE_HIGH>; > > > > Could you double check this is correct? Other OmniVision sensors have > > reset-gpios as active low. > > I have tested this, unfortunately I don't have access to a ov8856 > datasheet that includes > this level of detail. But I have tested this. > > > > > I suspect that the driver has also an inverted logic, so that's why it works. > > That could explain it still working. Let me have a look into the > driver and see what it does. > I had a look at some of OmniVision drivers, and there does seem to be a logical inversion in some of them, but not all of them. ov7251: - enable-gpios: Chip enable GPIO. Polarity is GPIO_ACTIVE_HIGH. This corresponds to the hardware pin XSHUTDOWN which is physically active low. ov5640: - reset-gpios: reference to the GPIO connected to the reset pin, if any. This is an active low signal to the OV5640. I think the confusion stems from the XSHUTDOWN pin being mapped to a GPIO called reset, and the two being logically inverted. Currently this series does several mappings. XSHUTDOWN -> reset-gpio -> n_shutdn_gpio ^ ^ ^ Physical Pin DT Driver I think changing to what ov5640 does makes the most sense. XSHUTDOWN -> reset-gpio -> reset_gpio > > > > I don't have access to the datasheet though, so I am just guessing. > > Me neither unfortunately, if anyone does have a link for it, I would > very much appreciate it.
diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml new file mode 100644 index 000000000000..c8099ccab1d9 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml @@ -0,0 +1,129 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (c) 2019 MediaTek Inc. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ov8856.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Omnivision OV8856 CMOS Sensor Device Tree Bindings + +maintainers: + - Ben Kao <ben.kao@intel.com> + - Dongchun Zhu <dongchun.zhu@mediatek.com> + +description: |- + The Omnivision OV8856 is a high performance, 1/4-inch, 8 megapixel, CMOS + image sensor that delivers 3264x2448 at 30fps. It provides full-frame, + sub-sampled, and windowed 10-bit MIPI images in various formats via the + Serial Camera Control Bus (SCCB) interface. This chip is programmable + through I2C and two-wire SCCB. The sensor output is available via CSI-2 + serial data output (up to 4-lane). + +properties: + compatible: + const: ovti,ov8856 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + description: + Input clock for the sensor. + items: + - const: xvclk + + clock-frequency: + description: + Frequency of the xvclk clock in Hertz. + + dovdd-supply: + description: + Definition of the regulator used as interface power supply. + + avdd-supply: + description: + Definition of the regulator used as analog power supply. + + dvdd-supply: + description: + Definition of the regulator used as digital power supply. + + reset-gpios: + description: + The phandle and specifier for the GPIO that controls sensor reset. + + port: + type: object + additionalProperties: false + description: + A node containing input and output port nodes with endpoint definitions + as documented in + Documentation/devicetree/bindings/media/video-interfaces.txt + + properties: + endpoint: + type: object + + properties: + clock-lanes: + maxItems: 1 + + data-lanes: + maxItems: 1 + + remote-endpoint: true + + required: + - clock-lanes + - data-lanes + - remote-endpoint + + required: + - endpoint + +required: + - compatible + - reg + - clocks + - clock-names + - clock-frequency + - dovdd-supply + - avdd-supply + - dvdd-supply + - reset-gpios + - port + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + ov8856: camera-sensor@10 { + compatible = "ovti,ov8856"; + reg = <0x10>; + reset-gpios = <&pio 111 GPIO_ACTIVE_HIGH>; + pinctrl-names = "default"; + pinctrl-0 = <&clk_24m_cam>; + + clocks = <&cru SCLK_TESTCLKOUT1>; + clock-names = "xvclk"; + clock-frequency = <19200000>; + + avdd-supply = <&mt6358_vcama2_reg>; + dvdd-supply = <&mt6358_vcamd_reg>; + dovdd-supply = <&mt6358_vcamio_reg>; + + port { + wcam_out: endpoint { + remote-endpoint = <&mipi_in_wcam>; + data-lanes = <1 2 3 4>; + link-frequencies = /bits/ 64 <360000000 180000000>; + }; + }; + }; + +... \ No newline at end of file diff --git a/MAINTAINERS b/MAINTAINERS index a6fbdf354d34..0f99e863978a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12355,6 +12355,7 @@ L: linux-media@vger.kernel.org T: git git://linuxtv.org/media_tree.git S: Maintained F: drivers/media/i2c/ov8856.c +F: Documentation/devicetree/bindings/media/i2c/ov8856.yaml OMNIVISION OV9650 SENSOR DRIVER M: Sakari Ailus <sakari.ailus@linux.intel.com>