diff mbox series

[3/3] ASoC: rt5682: Add the descriptions for the DMIC clock rate and delay settings

Message ID 20200317025240.10435-3-oder_chiou@realtek.com (mailing list archive)
State New, archived
Headers show
Series [1/3] ASoC: rt5682: Add a property for DMIC clock rate setting | expand

Commit Message

Oder Chiou March 17, 2020, 2:52 a.m. UTC
The patch adds the descriptions for the DMIC clock rate and delay settings.

Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
---
 Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Lars-Peter Clausen March 17, 2020, 10:46 a.m. UTC | #1
Hi,

On 3/17/20 3:52 AM, Oder Chiou wrote:
> The patch adds the descriptions for the DMIC clock rate and delay settings.
>
> Signed-off-by: Oder Chiou <oder_chiou@realtek.com>
> ---
>   Documentation/devicetree/bindings/sound/rt5682.txt | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
> index ac98151d29e4..0fb8a37d9b55 100644
> --- a/Documentation/devicetree/bindings/sound/rt5682.txt
> +++ b/Documentation/devicetree/bindings/sound/rt5682.txt
> @@ -38,6 +38,12 @@ Optional properties:
>   - clocks : phandle and clock specifier for codec MCLK.
>   - clock-names : Clock name string for 'clocks' attribute, should be "mclk".
>   
> +- realtek,dmic-clk-rate : Set the clock rate for the requirement of the
> +  particular DMIC.
Usually for devicetree property names 'clock' is not abbreviated. So 
'realtek,dmic-clock-rate' might be a better choice. Also mention in the 
description that it is in Hz.
> +
> +- realtek,dmic-delay : Set the delay time for the requirement of the
> +  particular DMIC.

What is the unit of the delay time. Usually for properties for duration 
there is also a suffix indicating the unit. E.g. realtk,dmic-delay-ms.

- Lars
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/rt5682.txt b/Documentation/devicetree/bindings/sound/rt5682.txt
index ac98151d29e4..0fb8a37d9b55 100644
--- a/Documentation/devicetree/bindings/sound/rt5682.txt
+++ b/Documentation/devicetree/bindings/sound/rt5682.txt
@@ -38,6 +38,12 @@  Optional properties:
 - clocks : phandle and clock specifier for codec MCLK.
 - clock-names : Clock name string for 'clocks' attribute, should be "mclk".
 
+- realtek,dmic-clk-rate : Set the clock rate for the requirement of the
+  particular DMIC.
+
+- realtek,dmic-delay : Set the delay time for the requirement of the
+  particular DMIC.
+
 Pins on the device (for linking into audio routes) for RT5682:
 
   * DMIC L1