| Message ID | 20200317144847.10913-1-idryomov@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | rbd: don't mess with a page vector in rbd_notify_op_lock() | expand |
On Tue, Mar 17, 2020 at 10:50 AM Ilya Dryomov <idryomov@gmail.com> wrote: > > rbd_notify_op_lock() isn't interested in a notify reply. Instead of > accepting that page vector just to free it, have watch-notify code take > care of it. > > Signed-off-by: Ilya Dryomov <idryomov@gmail.com> > --- > drivers/block/rbd.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c > index f44ce9ccadd6..acafdae16be2 100644 > --- a/drivers/block/rbd.c > +++ b/drivers/block/rbd.c > @@ -3754,11 +3754,7 @@ static int __rbd_notify_op_lock(struct rbd_device *rbd_dev, > static void rbd_notify_op_lock(struct rbd_device *rbd_dev, > enum rbd_notify_op notify_op) > { > - struct page **reply_pages; > - size_t reply_len; > - > - __rbd_notify_op_lock(rbd_dev, notify_op, &reply_pages, &reply_len); > - ceph_release_page_vector(reply_pages, calc_pages_for(0, reply_len)); > + __rbd_notify_op_lock(rbd_dev, notify_op, NULL, NULL); > } > > static void rbd_notify_acquired_lock(struct work_struct *work) > -- > 2.19.2 > Reviewed-by: Jason Dillaman <dillaman@redhat.com>
diff --git a/drivers/block/rbd.c b/drivers/block/rbd.c index f44ce9ccadd6..acafdae16be2 100644 --- a/drivers/block/rbd.c +++ b/drivers/block/rbd.c @@ -3754,11 +3754,7 @@ static int __rbd_notify_op_lock(struct rbd_device *rbd_dev, static void rbd_notify_op_lock(struct rbd_device *rbd_dev, enum rbd_notify_op notify_op) { - struct page **reply_pages; - size_t reply_len; - - __rbd_notify_op_lock(rbd_dev, notify_op, &reply_pages, &reply_len); - ceph_release_page_vector(reply_pages, calc_pages_for(0, reply_len)); + __rbd_notify_op_lock(rbd_dev, notify_op, NULL, NULL); } static void rbd_notify_acquired_lock(struct work_struct *work)
rbd_notify_op_lock() isn't interested in a notify reply. Instead of accepting that page vector just to free it, have watch-notify code take care of it. Signed-off-by: Ilya Dryomov <idryomov@gmail.com> --- drivers/block/rbd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)