| Message ID | 20200318100748.17540-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 3e566bee7f89de19727293c3ef1803b43c948d15 |
| Headers | show |
| Series | drivers/i2c/busses/i2c-imx.c:remove duplicate print after platform_get_irq() | expand |
On Wed, Mar 18, 2020 at 06:07:48PM +0800, Tang Bin wrote: > We don't need dev_err() message because when something goes wrong, > platform_get_irq() has print an error message itself, so we should > remove duplicate dev_err(). > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- > drivers/i2c/busses/i2c-imx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index a3b61336f..01fd46682 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -1066,10 +1066,8 @@ static int i2c_imx_probe(struct platform_device *pdev) > dev_dbg(&pdev->dev, "<%s>\n", __func__); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "can't get irq number\n"); > + if (irq < 0) > return irq; > - } Maybe add a comment for the next person who wonders about an error path without error message? Something like: irq = platform_get_irq(pdev, 0); if (irq < 0) /* * platform_get_irq() already issued an error message, so * fail silently here. */ return irq; And to get some extra kudos mention the commit that modified platform_get_irq() to emit a message in the commit log. Best regards Uwe
Hi Uwe, > Maybe add a comment for the next person who wonders about an error path > without error message? Something like: > > irq = platform_get_irq(pdev, 0); > if (irq < 0) > /* > * platform_get_irq() already issued an error message, so > * fail silently here. > */ > return irq; Hmm, too much boilerplate for my taste. I'd rather assume it will be printed during the call. > And to get some extra kudos mention the commit that modified > platform_get_irq() to emit a message in the commit log. Yes. Kind regards, Wolfram
On Wed, Mar 18, 2020 at 06:07:48PM +0800, Tang Bin wrote: > We don't need dev_err() message because when something goes wrong, > platform_get_irq() has print an error message itself, so we should > remove duplicate dev_err(). > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Acked-by: Oleksij Rempel <o.rempel@pengutronix.de> Thank you. > --- > drivers/i2c/busses/i2c-imx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c > index a3b61336f..01fd46682 100644 > --- a/drivers/i2c/busses/i2c-imx.c > +++ b/drivers/i2c/busses/i2c-imx.c > @@ -1066,10 +1066,8 @@ static int i2c_imx_probe(struct platform_device *pdev) > dev_dbg(&pdev->dev, "<%s>\n", __func__); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(&pdev->dev, "can't get irq number\n"); > + if (irq < 0) > return irq; > - } > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > base = devm_ioremap_resource(&pdev->dev, res); > -- > 2.20.1.windows.1 > > > >
On Wed, Mar 18, 2020 at 06:07:48PM +0800, Tang Bin wrote: > We don't need dev_err() message because when something goes wrong, > platform_get_irq() has print an error message itself, so we should > remove duplicate dev_err(). > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Applied to for-next, thanks! But please use a proper prefix in the subject next time ("i2c: imx: ...")
diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c index a3b61336f..01fd46682 100644 --- a/drivers/i2c/busses/i2c-imx.c +++ b/drivers/i2c/busses/i2c-imx.c @@ -1066,10 +1066,8 @@ static int i2c_imx_probe(struct platform_device *pdev) dev_dbg(&pdev->dev, "<%s>\n", __func__); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "can't get irq number\n"); + if (irq < 0) return irq; - } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap_resource(&pdev->dev, res);
We don't need dev_err() message because when something goes wrong, platform_get_irq() has print an error message itself, so we should remove duplicate dev_err(). Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/i2c/busses/i2c-imx.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)