| Message ID | 20200320094856.3453859-3-bigeasy@linutronix.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | c5eedbae2f2b5d340e4f69d25b03ac5878e0efc7 |
| Headers | show |
| Series | Remove mm.h from arch/*/include/asm/uaccess.h | expand |
Tested and Acked by me. Queued for next pull request, thx On Fri, Mar 20, 2020 at 5:49 PM Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > > The defconfig compiles without linux/mm.h. With mm.h included the > include chain leands to: > | CC kernel/locking/percpu-rwsem.o > | In file included from include/linux/huge_mm.h:8, > | from include/linux/mm.h:567, > | from arch/csky/include/asm/uaccess.h:, > | from include/linux/uaccess.h:11, > | from include/linux/sched/task.h:11, > | from include/linux/sched/signal.h:9, > | from include/linux/rcuwait.h:6, > | from include/linux/percpu-rwsem.h:8, > | from kernel/locking/percpu-rwsem.c:6: > | include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore' > | 1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS]; > > once rcuwait.h includes linux/sched/signal.h. > > Remove the linux/mm.h include. > > Cc: Guo Ren <guoren@kernel.org> > Cc: linux-csky@vger.kernel.org > Reported-by: kbuild test robot <lkp@intel.com> > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> > --- > arch/csky/include/asm/uaccess.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/csky/include/asm/uaccess.h b/arch/csky/include/asm/uaccess.h > index eaa1c3403a424..abefa125b93cf 100644 > --- a/arch/csky/include/asm/uaccess.h > +++ b/arch/csky/include/asm/uaccess.h > @@ -11,7 +11,6 @@ > #include <linux/errno.h> > #include <linux/types.h> > #include <linux/sched.h> > -#include <linux/mm.h> > #include <linux/string.h> > #include <linux/version.h> > #include <asm/segment.h> > -- > 2.26.0.rc2 >
Guo Ren <guoren@kernel.org> writes: > Tested and Acked by me. > > Queued for next pull request, thx Can we please route that with the rcuwait changes to avoid breakage unless you ship it to Linus right away? Thanks, tglx
On Sat, Mar 21, 2020 at 8:08 PM Thomas Gleixner <tglx@linutronix.de> wrote: > > Guo Ren <guoren@kernel.org> writes: > > > Tested and Acked by me. > > > > Queued for next pull request, thx > > Can we please route that with the rcuwait changes to avoid breakage > unless you ship it to Linus right away? Ok, I won't queue it.
diff --git a/arch/csky/include/asm/uaccess.h b/arch/csky/include/asm/uaccess.h index eaa1c3403a424..abefa125b93cf 100644 --- a/arch/csky/include/asm/uaccess.h +++ b/arch/csky/include/asm/uaccess.h @@ -11,7 +11,6 @@ #include <linux/errno.h> #include <linux/types.h> #include <linux/sched.h> -#include <linux/mm.h> #include <linux/string.h> #include <linux/version.h> #include <asm/segment.h>
The defconfig compiles without linux/mm.h. With mm.h included the include chain leands to: | CC kernel/locking/percpu-rwsem.o | In file included from include/linux/huge_mm.h:8, | from include/linux/mm.h:567, | from arch/csky/include/asm/uaccess.h:, | from include/linux/uaccess.h:11, | from include/linux/sched/task.h:11, | from include/linux/sched/signal.h:9, | from include/linux/rcuwait.h:6, | from include/linux/percpu-rwsem.h:8, | from kernel/locking/percpu-rwsem.c:6: | include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore' | 1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS]; once rcuwait.h includes linux/sched/signal.h. Remove the linux/mm.h include. Cc: Guo Ren <guoren@kernel.org> Cc: linux-csky@vger.kernel.org Reported-by: kbuild test robot <lkp@intel.com> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> --- arch/csky/include/asm/uaccess.h | 1 - 1 file changed, 1 deletion(-)