| Message ID | 20200320071337.59756-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] dmaengine: tegra-apb: mark PM functions as __maybe_unused | expand |
20.03.2020 10:13, YueHaibing пишет: > When CONFIG_PM is disabled, gcc warning this: > > drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function] > drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function] > > Make it as __maybe_unused to fix the warnings, > also remove unneeded function declarations. > > Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- ... Looks good, thank you: Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
On Fri, Mar 20, 2020 at 03:13:37PM +0800, YueHaibing wrote: > When CONFIG_PM is disabled, gcc warning this: > > drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function] > drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function] > > Make it as __maybe_unused to fix the warnings, > also remove unneeded function declarations. > > Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver") > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/dma/tegra20-apb-dma.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) Acked-by: Thierry Reding <treding@nvidia.com>
On 20-03-20, 15:13, YueHaibing wrote: > When CONFIG_PM is disabled, gcc warning this: > > drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function] > drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function] > > Make it as __maybe_unused to fix the warnings, > also remove unneeded function declarations. Applied, thanks
diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c index 4e295d121be6..b33000976f66 100644 --- a/drivers/dma/tegra20-apb-dma.c +++ b/drivers/dma/tegra20-apb-dma.c @@ -263,8 +263,6 @@ static inline struct device *tdc2dev(struct tegra_dma_channel *tdc) } static dma_cookie_t tegra_dma_tx_submit(struct dma_async_tx_descriptor *tx); -static int tegra_dma_runtime_suspend(struct device *dev); -static int tegra_dma_runtime_resume(struct device *dev); /* Get DMA desc from free list, if not there then allocate it. */ static struct tegra_dma_desc *tegra_dma_desc_get(struct tegra_dma_channel *tdc) @@ -1575,7 +1573,7 @@ static int tegra_dma_remove(struct platform_device *pdev) return 0; } -static int tegra_dma_runtime_suspend(struct device *dev) +static int __maybe_unused tegra_dma_runtime_suspend(struct device *dev) { struct tegra_dma *tdma = dev_get_drvdata(dev); @@ -1584,7 +1582,7 @@ static int tegra_dma_runtime_suspend(struct device *dev) return 0; } -static int tegra_dma_runtime_resume(struct device *dev) +static int __maybe_unused tegra_dma_runtime_resume(struct device *dev) { struct tegra_dma *tdma = dev_get_drvdata(dev);
When CONFIG_PM is disabled, gcc warning this: drivers/dma/tegra20-apb-dma.c:1587:12: warning: 'tegra_dma_runtime_resume' defined but not used [-Wunused-function] drivers/dma/tegra20-apb-dma.c:1578:12: warning: 'tegra_dma_runtime_suspend' defined but not used [-Wunused-function] Make it as __maybe_unused to fix the warnings, also remove unneeded function declarations. Fixes: ec8a1586780c ("dma: tegra: add dmaengine based dma driver") Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/dma/tegra20-apb-dma.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)