| Message ID | 20200309195216.31042-17-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: mxsfb: Add i.MX7 support | expand |
Hi Laurent, On Mon, Mar 9, 2020 at 4:53 PM Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > config DRM_MXSFB > - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller" > + tristate "i.MX23/i.MX28/i.MX6SX/i.MX7 MXSFB LCD controller" Can't we just make it simpler and write: tristate "i.MX eLCDIF controller" instead? Otherwise this list will get longer each time a new SoC is supported: tristate "i.MX23/i.MX28/i.MX6SX/i.MX6SL/i.MX7/i.MX7ULP/i.MX8M/i.MX8MM/i.MX8QXP/i.MX8M MXSFB LCD controller" and probably more :-)
Hi Fabio, On Tue, Mar 10, 2020 at 01:28:35PM -0300, Fabio Estevam wrote: > On Mon, Mar 9, 2020 at 4:53 PM Laurent Pinchart wrote: > > > config DRM_MXSFB > > - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller" > > + tristate "i.MX23/i.MX28/i.MX6SX/i.MX7 MXSFB LCD controller" > > Can't we just make it simpler and write: tristate "i.MX eLCDIF > controller" instead? It should then be "LCDIF and eLCDIF controllers" or "(e)LCDIF controller", as the versions prior to i.MX6 were LCDIF and got later extended to eLCDIF. > Otherwise this list will get longer each time a new SoC is supported: > > tristate "i.MX23/i.MX28/i.MX6SX/i.MX6SL/i.MX7/i.MX7ULP/i.MX8M/i.MX8MM/i.MX8QXP/i.MX8M > MXSFB LCD controller" > > and probably more :-) It's a good point, and I agree. I'll fix this.
On 2020-03-09 20:52, Laurent Pinchart wrote: > Extend the Kconfig option description by listing the i.MX7 SoCs, as they > are supported by the same driver. Can you also add "i.MX8M" to the list since the bindings for this driver are also used in arch/arm64/boot/dts/freescale/imx8mq.dtsi. -- Stefan > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/mxsfb/Kconfig | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mxsfb/Kconfig b/drivers/gpu/drm/mxsfb/Kconfig > index 0dca8f27169e..e91841f8f8a2 100644 > --- a/drivers/gpu/drm/mxsfb/Kconfig > +++ b/drivers/gpu/drm/mxsfb/Kconfig > @@ -5,7 +5,7 @@ config DRM_MXS > Choose this option to select drivers for MXS FB devices > > config DRM_MXSFB > - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller" > + tristate "i.MX23/i.MX28/i.MX6SX/i.MX7 MXSFB LCD controller" > depends on DRM && OF > depends on COMMON_CLK > select DRM_MXS > @@ -14,7 +14,7 @@ config DRM_MXSFB > select DRM_KMS_CMA_HELPER > select DRM_PANEL > help > - Choose this option if you have an i.MX23/i.MX28/i.MX6SX MXSFB > + Choose this option if you have an i.MX23/i.MX28/i.MX6SX/i.MX7 MXSFB > LCD controller. > > If M is selected the module will be called mxsfb.
diff --git a/drivers/gpu/drm/mxsfb/Kconfig b/drivers/gpu/drm/mxsfb/Kconfig index 0dca8f27169e..e91841f8f8a2 100644 --- a/drivers/gpu/drm/mxsfb/Kconfig +++ b/drivers/gpu/drm/mxsfb/Kconfig @@ -5,7 +5,7 @@ config DRM_MXS Choose this option to select drivers for MXS FB devices config DRM_MXSFB - tristate "i.MX23/i.MX28/i.MX6SX MXSFB LCD controller" + tristate "i.MX23/i.MX28/i.MX6SX/i.MX7 MXSFB LCD controller" depends on DRM && OF depends on COMMON_CLK select DRM_MXS @@ -14,7 +14,7 @@ config DRM_MXSFB select DRM_KMS_CMA_HELPER select DRM_PANEL help - Choose this option if you have an i.MX23/i.MX28/i.MX6SX MXSFB + Choose this option if you have an i.MX23/i.MX28/i.MX6SX/i.MX7 MXSFB LCD controller. If M is selected the module will be called mxsfb.
Extend the Kconfig option description by listing the i.MX7 SoCs, as they are supported by the same driver. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- drivers/gpu/drm/mxsfb/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)