| Message ID | 20200323234505.226919-1-rajatja@google.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [RESEND,1/5] input/serio/i8042: Attach fwnode to serio i8042 kbd device | expand |
On Mon, Mar 23, 2020 at 04:45:01PM -0700, Rajat Jain wrote: > Attach the firmware node to the serio i8042 kbd device so that device > properties can be passed from the firmware. > > Signed-off-by: Rajat Jain <rajatja@google.com> > Change-Id: I36032f4bdee1dc52f26b57734068fd0ee7a6db0b Didn't you run checkpatch.pl on your patches which told you to remove all of these Change-Id: values? Please do so... greg k-h
Hello, On Tue, Mar 24, 2020 at 4:51 AM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Mon, Mar 23, 2020 at 04:45:01PM -0700, Rajat Jain wrote: > > Attach the firmware node to the serio i8042 kbd device so that device > > properties can be passed from the firmware. > > > > Signed-off-by: Rajat Jain <rajatja@google.com> > > Change-Id: I36032f4bdee1dc52f26b57734068fd0ee7a6db0b > > Didn't you run checkpatch.pl on your patches which told you to remove > all of these Change-Id: values? My apologies. However I did run checkpatch.pl on my patches before sending (also checked just now again) and it did not complain about the Change-Id values in the commit log. Not sure if I'm running the command incorrectly? rajatja@rajat2:~/stock_kernel/linux$ ./scripts/checkpatch.pl ../patches/input_atkbd/v1/000* ----------------------------------------------------------------------------------------- ../patches/input_atkbd/v1/0001-input-serio-i8042-Attach-fwnode-to-serio-i8042-kbd-d.patch ----------------------------------------------------------------------------------------- total: 0 errors, 0 warnings, 28 lines checked ../patches/input_atkbd/v1/0001-input-serio-i8042-Attach-fwnode-to-serio-i8042-kbd-d.patch has no obvious style problems and is ready for submission. ----------------------------------------------------------------------------------------- ../patches/input_atkbd/v1/0002-Input-atkbd-Expose-function-row-physical-map-to-user.patch ----------------------------------------------------------------------------------------- total: 0 errors, 0 warnings, 106 lines checked ../patches/input_atkbd/v1/0002-Input-atkbd-Expose-function-row-physical-map-to-user.patch has no obvious style problems and is ready for submission. ...... <snip> ...... I will now resubmit the patches removing the Change-Id(s). Thanks & Best Regards, Rajat > > Please do so... > > greg k-h
diff --git a/drivers/input/serio/i8042-x86ia64io.h b/drivers/input/serio/i8042-x86ia64io.h index dc974c288e880..ed9ec4310d976 100644 --- a/drivers/input/serio/i8042-x86ia64io.h +++ b/drivers/input/serio/i8042-x86ia64io.h @@ -927,6 +927,7 @@ static int i8042_pnp_kbd_probe(struct pnp_dev *dev, const struct pnp_device_id * } i8042_pnp_id_to_string(dev->id, i8042_kbd_firmware_id, sizeof(i8042_kbd_firmware_id)); + i8042_kbd_fwnode = dev_fwnode(&dev->dev); /* Keyboard ports are always supposed to be wakeup-enabled */ device_set_wakeup_enable(&dev->dev, true); diff --git a/drivers/input/serio/i8042.c b/drivers/input/serio/i8042.c index 20ff2bed3917a..0dddf273afd94 100644 --- a/drivers/input/serio/i8042.c +++ b/drivers/input/serio/i8042.c @@ -21,6 +21,7 @@ #include <linux/i8042.h> #include <linux/slab.h> #include <linux/suspend.h> +#include <linux/property.h> #include <asm/io.h> @@ -124,6 +125,7 @@ MODULE_PARM_DESC(unmask_kbd_data, "Unconditional enable (may reveal sensitive da static bool i8042_bypass_aux_irq_test; static char i8042_kbd_firmware_id[128]; static char i8042_aux_firmware_id[128]; +static struct fwnode_handle *i8042_kbd_fwnode; #include "i8042.h" @@ -1335,6 +1337,7 @@ static int __init i8042_create_kbd_port(void) strlcpy(serio->phys, I8042_KBD_PHYS_DESC, sizeof(serio->phys)); strlcpy(serio->firmware_id, i8042_kbd_firmware_id, sizeof(serio->firmware_id)); + set_primary_fwnode(&serio->dev, i8042_kbd_fwnode); port->serio = serio; port->irq = I8042_KBD_IRQ;
Attach the firmware node to the serio i8042 kbd device so that device properties can be passed from the firmware. Signed-off-by: Rajat Jain <rajatja@google.com> Change-Id: I36032f4bdee1dc52f26b57734068fd0ee7a6db0b --- drivers/input/serio/i8042-x86ia64io.h | 1 + drivers/input/serio/i8042.c | 3 +++ 2 files changed, 4 insertions(+)