| Message ID | 20200324122921.29582-1-guennadi.liakhovetski@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | ASoC: SOF: initialise work immediately | expand |
On Tue, Mar 24, 2020 at 01:29:19PM +0100, Guennadi Liakhovetski wrote: > Fix uninitialised work errors by moving initialisation to directly > after allocation. > > Guennadi Liakhovetski (2): > ASoC: SOF: (cosmetic) use for_each_pcm_streams() in sof_dai_load() > ASoC: SOF: fix uninitialised "work" with VirtIO As documented in submitting-patches.rst please send patches to the maintainers for the code you would like to change. The normal kernel workflow is that people apply patches from their inboxes, if they aren't copied they are likely to not see the patch at all and it is much more difficult to apply patches.
Hi Mark, On Tue, Mar 24, 2020 at 01:30:42PM +0000, Mark Brown wrote: > On Tue, Mar 24, 2020 at 01:29:19PM +0100, Guennadi Liakhovetski wrote: > > Fix uninitialised work errors by moving initialisation to directly > > after allocation. > > > > Guennadi Liakhovetski (2): > > ASoC: SOF: (cosmetic) use for_each_pcm_streams() in sof_dai_load() > > ASoC: SOF: fix uninitialised "work" with VirtIO > > As documented in submitting-patches.rst please send patches to the > maintainers for the code you would like to change. The normal kernel > workflow is that people apply patches from their inboxes, if they aren't > copied they are likely to not see the patch at all and it is much more > difficult to apply patches. I know that different maintainers have different preferences. For example in the subsysteem, where I'd worked for about 10 years the maintainer preferred not to be CCed on patches, he preferred to pick up patches from his mailing list folders, or whatever arrangement his mail filters provided for. I learned already that in ALSA / ASoC it's usual to CC maintainers. But I wasn't sure whether that also holds for larger patch series. E.g. my main patch series now consists of 14 patches, so, I thought, that maybe you would rather not receive multiple copies of the entire seriees for each new version both directly in your inbox and in the mailing list folder. Or is it indeed your preference to always be CCed on all patches? I apologise for re-iterating a question, that probably had been addressed multiple times before, maybe it's worth documenting this somewhere on ALSA web? Thanks Guennadi
On Tue, Mar 24, 2020 at 02:58:56PM +0100, Guennadi Liakhovetski wrote: > On Tue, Mar 24, 2020 at 01:30:42PM +0000, Mark Brown wrote: > > As documented in submitting-patches.rst please send patches to the > > maintainers for the code you would like to change. The normal kernel > > workflow is that people apply patches from their inboxes, if they aren't > > copied they are likely to not see the patch at all and it is much more > > difficult to apply patches. > I know that different maintainers have different preferences. For example > in the subsysteem, where I'd worked for about 10 years the maintainer > preferred not to be CCed on patches, he preferred to pick up patches from > his mailing list folders, or whatever arrangement his mail filters > provided for. I learned already that in ALSA / ASoC it's usual to CC > maintainers. But I wasn't sure whether that also holds for larger patch > series. E.g. my main patch series now consists of 14 patches, so, I > thought, that maybe you would rather not receive multiple copies of the > entire seriees for each new version both directly in your inbox and in > the mailing list folder. Or is it indeed your preference to always be > CCed on all patches? I apologise for re-iterating a question, that > probably had been addressed multiple times before, maybe it's worth > documenting this somewhere on ALSA web? Yes, copy me on patches. This is, as covered in what I wrote above, the standard and documented approach for the kernel - unless you explicitly know that there is some unusual approach for a specific subsystem you should assume that if you want people to see your patches you need to send the patches to them.
Hi Mark, On Tue, Mar 24, 2020 at 01:30:42PM +0000, Mark Brown wrote: > On Tue, Mar 24, 2020 at 01:29:19PM +0100, Guennadi Liakhovetski wrote: > > Fix uninitialised work errors by moving initialisation to directly > > after allocation. > > > > Guennadi Liakhovetski (2): > > ASoC: SOF: (cosmetic) use for_each_pcm_streams() in sof_dai_load() > > ASoC: SOF: fix uninitialised "work" with VirtIO > > As documented in submitting-patches.rst please send patches to the > maintainers for the code you would like to change. The normal kernel > workflow is that people apply patches from their inboxes, if they aren't > copied they are likely to not see the patch at all and it is much more > difficult to apply patches. An update: these patches got merged into the SOF tree, so, no need to merge them to ASoC directly. Thanks Guennadi
On Tue, Mar 24, 2020 at 02:48:22PM +0000, Mark Brown wrote: > On Tue, Mar 24, 2020 at 02:58:56PM +0100, Guennadi Liakhovetski wrote: > > On Tue, Mar 24, 2020 at 01:30:42PM +0000, Mark Brown wrote: > > > > As documented in submitting-patches.rst please send patches to the > > > maintainers for the code you would like to change. The normal kernel > > > workflow is that people apply patches from their inboxes, if they aren't > > > copied they are likely to not see the patch at all and it is much more > > > difficult to apply patches. > > > I know that different maintainers have different preferences. For example > > in the subsysteem, where I'd worked for about 10 years the maintainer > > preferred not to be CCed on patches, he preferred to pick up patches from > > his mailing list folders, or whatever arrangement his mail filters > > provided for. I learned already that in ALSA / ASoC it's usual to CC > > maintainers. But I wasn't sure whether that also holds for larger patch > > series. E.g. my main patch series now consists of 14 patches, so, I > > thought, that maybe you would rather not receive multiple copies of the > > entire seriees for each new version both directly in your inbox and in > > the mailing list folder. Or is it indeed your preference to always be > > CCed on all patches? I apologise for re-iterating a question, that > > probably had been addressed multiple times before, maybe it's worth > > documenting this somewhere on ALSA web? > > Yes, copy me on patches. This is, as covered in what I wrote above, the > standard and documented approach for the kernel - unless you explicitly > know that there is some unusual approach for a specific subsystem you > should assume that if you want people to see your patches you need to > send the patches to them. Got it, thanks!
On Wed, Mar 25, 2020 at 12:10:12PM +0100, Guennadi Liakhovetski wrote: > On Tue, Mar 24, 2020 at 01:30:42PM +0000, Mark Brown wrote: > > As documented in submitting-patches.rst please send patches to the > > maintainers for the code you would like to change. The normal kernel > > workflow is that people apply patches from their inboxes, if they aren't > > copied they are likely to not see the patch at all and it is much more > > difficult to apply patches. > An update: these patches got merged into the SOF tree, so, no need to > merge them to ASoC directly. OK, for reference it's not normal to submit things to both SOF and to upstream - one or the other is more normal.