| Message ID | 20200316075302.3759-2-dmastykin@astralinux.ru (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 24ef83f6e31d20fc121a7cd732b04b498475fca3 |
| Headers | show |
| Series | [v3,1/2] Input: goodix - Add support for more then one touch-key | expand |
On Mon, 2020-03-16 at 10:53 +0300, Dmitry Mastykin wrote: > The goodix panel sends spurious interrupts after a 'finger up' event, > which always cause a timeout. > We were exiting the interrupt handler by reporting touch_num == 0, > but > this was still processed as valid and caused the code to use the > uninitialised point_data, creating spurious key release events. > > Report an error from the interrupt handler so as to avoid processing > invalid point_data further. > > Signed-off-by: Dmitry Mastykin <dmastykin@astralinux.ru> LGTM Reviewed-by: Bastien Nocera <hadess@hadess.net> > --- > Changes in v3: > - Improve commit message > > Changes in v2: > - Improve commit message > --- > drivers/input/touchscreen/goodix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/goodix.c > b/drivers/input/touchscreen/goodix.c > index 04b5c7b..cc965fe 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -329,7 +329,7 @@ static int goodix_ts_read_input_report(struct > goodix_ts_data *ts, u8 *data) > * The Goodix panel will send spurious interrupts after a > * 'finger up' event, which will always cause a timeout. > */ > - return 0; > + return -ENOMSG; > } > > static void goodix_ts_report_touch_8b(struct goodix_ts_data *ts, u8 > *coor_data)
On Mon, Mar 16, 2020 at 10:53:05AM +0300, Dmitry Mastykin wrote: > The goodix panel sends spurious interrupts after a 'finger up' event, > which always cause a timeout. > We were exiting the interrupt handler by reporting touch_num == 0, but > this was still processed as valid and caused the code to use the > uninitialised point_data, creating spurious key release events. > > Report an error from the interrupt handler so as to avoid processing > invalid point_data further. > > Signed-off-by: Dmitry Mastykin <dmastykin@astralinux.ru> Applied, thank you. > --- > Changes in v3: > - Improve commit message > > Changes in v2: > - Improve commit message > --- > drivers/input/touchscreen/goodix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c > index 04b5c7b..cc965fe 100644 > --- a/drivers/input/touchscreen/goodix.c > +++ b/drivers/input/touchscreen/goodix.c > @@ -329,7 +329,7 @@ static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data) > * The Goodix panel will send spurious interrupts after a > * 'finger up' event, which will always cause a timeout. > */ > - return 0; > + return -ENOMSG; > } > > static void goodix_ts_report_touch_8b(struct goodix_ts_data *ts, u8 *coor_data) > -- > 2.23.0 >
diff --git a/drivers/input/touchscreen/goodix.c b/drivers/input/touchscreen/goodix.c index 04b5c7b..cc965fe 100644 --- a/drivers/input/touchscreen/goodix.c +++ b/drivers/input/touchscreen/goodix.c @@ -329,7 +329,7 @@ static int goodix_ts_read_input_report(struct goodix_ts_data *ts, u8 *data) * The Goodix panel will send spurious interrupts after a * 'finger up' event, which will always cause a timeout. */ - return 0; + return -ENOMSG; } static void goodix_ts_report_touch_8b(struct goodix_ts_data *ts, u8 *coor_data)
The goodix panel sends spurious interrupts after a 'finger up' event, which always cause a timeout. We were exiting the interrupt handler by reporting touch_num == 0, but this was still processed as valid and caused the code to use the uninitialised point_data, creating spurious key release events. Report an error from the interrupt handler so as to avoid processing invalid point_data further. Signed-off-by: Dmitry Mastykin <dmastykin@astralinux.ru> --- Changes in v3: - Improve commit message Changes in v2: - Improve commit message --- drivers/input/touchscreen/goodix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)