diff mbox series

[1/3] dt-bindings: usb: usb-xhci: add r8a77961 support

Message ID 1585117006-8266-2-git-send-email-yoshihiro.shimoda.uh@renesas.com (mailing list archive)
State Superseded
Headers show
Series dt-bindings: usb: add r8a77961 support | expand

Commit Message

Yoshihiro Shimoda March 25, 2020, 6:16 a.m. UTC
This patch adds support for r8a77961 (R-Car M3-W+).

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 Documentation/devicetree/bindings/usb/usb-xhci.txt | 1 +
 1 file changed, 1 insertion(+)

Comments

Geert Uytterhoeven March 25, 2020, 12:57 p.m. UTC | #1
Hi Shimoda-san,

On Wed, Mar 25, 2020 at 7:17 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> This patch adds support for r8a77961 (R-Car M3-W+).
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> @@ -17,6 +17,7 @@ Required properties:
>      - "renesas,xhci-r8a7793" for r8a7793 SoC
>      - "renesas,xhci-r8a7795" for r8a7795 SoC
>      - "renesas,xhci-r8a7796" for r8a7796 SoC

While at it, you may want to update "r8a7796 SoC" to "r8a77960 SoC", to
avoid confusion between R-Car M3-W (R8A77960) and M3-W+ (R8A77961).

> +    - "renesas,xhci-r8a77961" for r8a77961 SoC
>      - "renesas,xhci-r8a77965" for r8a77965 SoC
>      - "renesas,xhci-r8a77990" for r8a77990 SoC
>      - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 or RZ/G1 compatible

With that fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Yoshihiro Shimoda March 26, 2020, 2:11 a.m. UTC | #2
Hi Geert-san,

Thank you for your review!

> From: Geert Uytterhoeven, Sent: Wednesday, March 25, 2020 9:58 PM
<snip>
> Hi Shimoda-san,
> > --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
> > @@ -17,6 +17,7 @@ Required properties:
> >      - "renesas,xhci-r8a7793" for r8a7793 SoC
> >      - "renesas,xhci-r8a7795" for r8a7795 SoC
> >      - "renesas,xhci-r8a7796" for r8a7796 SoC
> 
> While at it, you may want to update "r8a7796 SoC" to "r8a77960 SoC", to
> avoid confusion between R-Car M3-W (R8A77960) and M3-W+ (R8A77961).

I got it. I'll fix it and add such a description to the commit log.

> > +    - "renesas,xhci-r8a77961" for r8a77961 SoC
> >      - "renesas,xhci-r8a77965" for r8a77965 SoC
> >      - "renesas,xhci-r8a77990" for r8a77990 SoC
> >      - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 or RZ/G1 compatible
> 
> With that fixed:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks!

Best regards,
Yoshihiro Shimoda
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt
index 3f37895..ce4162e 100644
--- a/Documentation/devicetree/bindings/usb/usb-xhci.txt
+++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt
@@ -17,6 +17,7 @@  Required properties:
     - "renesas,xhci-r8a7793" for r8a7793 SoC
     - "renesas,xhci-r8a7795" for r8a7795 SoC
     - "renesas,xhci-r8a7796" for r8a7796 SoC
+    - "renesas,xhci-r8a77961" for r8a77961 SoC
     - "renesas,xhci-r8a77965" for r8a77965 SoC
     - "renesas,xhci-r8a77990" for r8a77990 SoC
     - "renesas,rcar-gen2-xhci" for a generic R-Car Gen2 or RZ/G1 compatible