| Message ID | 20200326182711.GA259753@dtor-ws (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | fbf66796a0aedbaea248c7ade1459ccd0dd4cb44 |
| Headers | show |
| Series | Input: move the new KEY_SELECTIVE_SCREENSHOT keycode | expand |
On Thu, Mar 26, 2020 at 11:27 AM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > We should try to keep keycodes sequential unless there is a reason to leave > a gap in numbering, so let's move it from 0x280 to 0x27a while we still > can. > > Fixes: 3b059da9835c ("Input: allocate keycode for Selective Screenshot key") > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Acked-by: Rajat Jain <rajatja@google.com> Thanks! My apologies for overlooking. > --- > include/uapi/linux/input-event-codes.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h > index 008be2609ce1..6923dc7e0298 100644 > --- a/include/uapi/linux/input-event-codes.h > +++ b/include/uapi/linux/input-event-codes.h > @@ -653,7 +653,7 @@ > #define KEY_PRIVACY_SCREEN_TOGGLE 0x279 > > /* Select an area of screen to be copied */ > -#define KEY_SELECTIVE_SCREENSHOT 0x280 > +#define KEY_SELECTIVE_SCREENSHOT 0x27a > > /* > * Some keyboards have keys which do not have a defined meaning, these keys > -- > 2.26.0.rc2.310.g2932bb562d-goog > > > -- > Dmitry
diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h index 008be2609ce1..6923dc7e0298 100644 --- a/include/uapi/linux/input-event-codes.h +++ b/include/uapi/linux/input-event-codes.h @@ -653,7 +653,7 @@ #define KEY_PRIVACY_SCREEN_TOGGLE 0x279 /* Select an area of screen to be copied */ -#define KEY_SELECTIVE_SCREENSHOT 0x280 +#define KEY_SELECTIVE_SCREENSHOT 0x27a /* * Some keyboards have keys which do not have a defined meaning, these keys
We should try to keep keycodes sequential unless there is a reason to leave a gap in numbering, so let's move it from 0x280 to 0x27a while we still can. Fixes: 3b059da9835c ("Input: allocate keycode for Selective Screenshot key") Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- include/uapi/linux/input-event-codes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)