| Message ID | 20200330063034.27309-1-skashyap@marvell.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | qed/qedf: Firmware recovery, bw update and misc fixes. | expand |
On Sun, Mar 29, 2020 at 11:30:26PM -0700, Saurav Kashyap wrote: > Hi Martin, > > Kindly apply this series to scsi tree at your earliest convenience. > > v1->v2 > - Function qedf_schedule_recovery_handler marked static > - Function qedf_recovery_handler marked static > > Thanks, > ~Saurav > > Chad Dupuis (2): > qedf: Add schedule recovery handler. > qedf: Fix crash when MFW calls for protocol stats while function is > still probing. > > Javed Hasan (1): > qedf: Fix for the deviations from the SAM-4 spec. > > Saurav Kashyap (4): > qedf: Keep track of num of pending flogi. > qedf: Implement callback for bw_update. > qedf: Get dev info after updating the params. > qedf: Update the driver version to 8.42.3.5. NAK to this patch. Thanks
You add the new qed_bw_update() function but nothing invokes it. Remove this from the patch series until you are submitting changes that actually use the function.
Hi David, > -----Original Message----- > From: David Miller <davem@davemloft.net> > Sent: Monday, March 30, 2020 10:42 PM > To: Saurav Kashyap <skashyap@marvell.com> > Cc: martin.petersen@oracle.com; GR-QLogic-Storage-Upstream <GR-QLogic- > Storage-Upstream@marvell.com>; linux-scsi@vger.kernel.org; Javed Hasan > <jhasan@marvell.com>; netdev@vger.kernel.org > Subject: [EXT] Re: [PATCH v2 0/8] qed/qedf: Firmware recovery, bw update > and misc fixes. > > External Email > > ---------------------------------------------------------------------- > > You add the new qed_bw_update() function but nothing invokes it. > > Remove this from the patch series until you are submitting changes > that actually use the function. qedf driver does use this call, I have submitted following patches. The patch "Implement callback for bw_update" uses functionality exposed by qed. Its patch number 4 in the series. Saurav Kashyap (4): qedf: Keep track of num of pending flogi. qedf: Implement callback for bw_update. qedf: Get dev info after updating the params. qedf: Update the driver version to 8.42.3.5. Sudarsana Reddy Kalluru (1): qed: Send BW update notifications to the protocol drivers. Thanks, ~Saurav
Hi Martin, Kindly apply this series to scsi tree at your earliest convenience. v1->v2 - Function qedf_schedule_recovery_handler marked static - Function qedf_recovery_handler marked static Thanks, ~Saurav Chad Dupuis (2): qedf: Add schedule recovery handler. qedf: Fix crash when MFW calls for protocol stats while function is still probing. Javed Hasan (1): qedf: Fix for the deviations from the SAM-4 spec. Saurav Kashyap (4): qedf: Keep track of num of pending flogi. qedf: Implement callback for bw_update. qedf: Get dev info after updating the params. qedf: Update the driver version to 8.42.3.5. Sudarsana Reddy Kalluru (1): qed: Send BW update notifications to the protocol drivers. drivers/net/ethernet/qlogic/qed/qed.h | 1 + drivers/net/ethernet/qlogic/qed/qed_main.c | 9 ++ drivers/scsi/qedf/qedf.h | 6 +- drivers/scsi/qedf/qedf_io.c | 47 +++++++--- drivers/scsi/qedf/qedf_main.c | 135 ++++++++++++++++++++++++++++- drivers/scsi/qedf/qedf_version.h | 4 +- include/linux/qed/qed_if.h | 1 + 7 files changed, 186 insertions(+), 17 deletions(-)