| Message ID | 1585562347-30214-1-git-send-email-dingxiang@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4c1cb04e0e7ac4ba1ef5457929ef9b5671d9eed3 |
| Headers | show |
| Series | drm/xen: fix passing zero to 'PTR_ERR' warning | expand |
On 3/30/20 12:59, Ding Xiang wrote: > Fix a static code checker warning: > drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create() > warn: passing zero to 'PTR_ERR' > > Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> > --- > drivers/gpu/drm/xen/xen_drm_front.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c > index 4be49c1..3741420 100644 > --- a/drivers/gpu/drm/xen/xen_drm_front.c > +++ b/drivers/gpu/drm/xen/xen_drm_front.c > @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp, > > obj = xen_drm_front_gem_create(dev, args->size); > if (IS_ERR_OR_NULL(obj)) { > - ret = PTR_ERR(obj); > + ret = PTR_ERR_OR_ZERO(obj); > goto fail; > } >
On Tue, Mar 31, 2020 at 05:50:10PM +0300, Oleksandr Andrushchenko wrote: > On 3/30/20 12:59, Ding Xiang wrote: > > Fix a static code checker warning: > > drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create() > > warn: passing zero to 'PTR_ERR' > > > > Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> > Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com> merged to drm-misc-next-fixese. -Daniel > > --- > > drivers/gpu/drm/xen/xen_drm_front.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c > > index 4be49c1..3741420 100644 > > --- a/drivers/gpu/drm/xen/xen_drm_front.c > > +++ b/drivers/gpu/drm/xen/xen_drm_front.c > > @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp, > > obj = xen_drm_front_gem_create(dev, args->size); > > if (IS_ERR_OR_NULL(obj)) { > > - ret = PTR_ERR(obj); > > + ret = PTR_ERR_OR_ZERO(obj); > > goto fail; > > }
diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c index 4be49c1..3741420 100644 --- a/drivers/gpu/drm/xen/xen_drm_front.c +++ b/drivers/gpu/drm/xen/xen_drm_front.c @@ -401,7 +401,7 @@ static int xen_drm_drv_dumb_create(struct drm_file *filp, obj = xen_drm_front_gem_create(dev, args->size); if (IS_ERR_OR_NULL(obj)) { - ret = PTR_ERR(obj); + ret = PTR_ERR_OR_ZERO(obj); goto fail; }
Fix a static code checker warning: drivers/gpu/drm/xen/xen_drm_front.c:404 xen_drm_drv_dumb_create() warn: passing zero to 'PTR_ERR' Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com> --- drivers/gpu/drm/xen/xen_drm_front.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)