| Message ID | 20200405233935.27599-1-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | dt-bindings: display: Convert DWC HDMI TX bindings to YAML | expand |
On Mon, Apr 06, 2020 at 02:39:29AM +0300, Laurent Pinchart wrote: > Hello, > > This patch series attempts a conversion of the DWC HDMI TX DT bindings > to YAML. I've marked it as RFC as the base schema doesn't work is > intended in this (naive) approach, and I'm not sure how to fix it > properly. > > The DWC HDMI TX is an HDMI transmitter IP core from Synopsys, integrated > in various SoCs with different glue layers. As such, some properties are > defined in a common document, but sometimes need to be overridden by > platform-specific bindings. > > Patch 1/6 adds a base schema for the common properties, based on the > existing dw_hdmi.txt document. Patches 2/6 to 4/6 then convert the > platformspecific bindings for Renesas, NXP and Rockchip SoCs. Patch 5/6 > replaces the reference to dw_hdmi.txt in the Allwinner bindings with a > reference to the YAML base schema, and patch 6/6 drops dw_hdmi.txt. > > My attempts at defining properties in the base schema, including it in > the platform-specific schema with an allOf: $ref..., and overridding > properties didn't work, as DT schemas don't define properties in a way > that can be overridden, but instead define validation rules that are all > considered. Both the rules in the base schema and in the > platform-specific schemas are evaluated. > > One possible way around this would be to not pull in the whole base > schema, but specific rules. This is however a bit cumbersome to use in > my opinion. Is there a better way to achieve this ? > > I have volunteered Philipp Zabel and Mark Yao as maintainers for the > i.MX6 and Rockchip bindings respectively. Please let me know if you > would prefer a different maintainer, or ack the respective patch if this > is fine with you. Given that <mark.yao@rock-chips.com> bounced, I may already have an answer to part of that question :-) I've CC'ed Mark's gmail address, as well as Sandy and Heiko who maintain the Rockchip DRM driver. > Laurent Pinchart (6): > dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI > dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML > dt-bindings: display: imx: hdmi: Convert binding to YAML > dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML > dt-bindings: display: sun8i-a83t-dw-hdmi: Reference dw-hdmi YAML > schema > dt-bindings: display: bridge: Remove deprecated dw_hdmi.txt > > .../display/allwinner,sun8i-a83t-dw-hdmi.yaml | 4 +- > .../bindings/display/bridge/dw_hdmi.txt | 33 ---- > .../display/bridge/renesas,dw-hdmi.txt | 86 --------- > .../display/bridge/renesas,dw-hdmi.yaml | 142 ++++++++++++++ > .../display/bridge/synopsys,dw-hdmi.yaml | 68 +++++++ > .../bindings/display/imx/fsl,imx6-hdmi.yaml | 143 ++++++++++++++ > .../devicetree/bindings/display/imx/hdmi.txt | 65 ------- > .../display/rockchip/dw_hdmi-rockchip.txt | 74 -------- > .../display/rockchip/rockchip,dw-hdmi.yaml | 178 ++++++++++++++++++ > 9 files changed, 533 insertions(+), 260 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/dw_hdmi.txt > delete mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt > create mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml > create mode 100644 Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml > create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml > delete mode 100644 Documentation/devicetree/bindings/display/imx/hdmi.txt > delete mode 100644 Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt > create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml
Hello, This patch series attempts a conversion of the DWC HDMI TX DT bindings to YAML. I've marked it as RFC as the base schema doesn't work is intended in this (naive) approach, and I'm not sure how to fix it properly. The DWC HDMI TX is an HDMI transmitter IP core from Synopsys, integrated in various SoCs with different glue layers. As such, some properties are defined in a common document, but sometimes need to be overridden by platform-specific bindings. Patch 1/6 adds a base schema for the common properties, based on the existing dw_hdmi.txt document. Patches 2/6 to 4/6 then convert the platformspecific bindings for Renesas, NXP and Rockchip SoCs. Patch 5/6 replaces the reference to dw_hdmi.txt in the Allwinner bindings with a reference to the YAML base schema, and patch 6/6 drops dw_hdmi.txt. My attempts at defining properties in the base schema, including it in the platform-specific schema with an allOf: $ref..., and overridding properties didn't work, as DT schemas don't define properties in a way that can be overridden, but instead define validation rules that are all considered. Both the rules in the base schema and in the platform-specific schemas are evaluated. One possible way around this would be to not pull in the whole base schema, but specific rules. This is however a bit cumbersome to use in my opinion. Is there a better way to achieve this ? I have volunteered Philipp Zabel and Mark Yao as maintainers for the i.MX6 and Rockchip bindings respectively. Please let me know if you would prefer a different maintainer, or ack the respective patch if this is fine with you. Laurent Pinchart (6): dt-bindings: display: bridge: Add YAML schema for Synopsys DW-HDMI dt-bindings: display: bridge: renesas,dw-hdmi: Convert binding to YAML dt-bindings: display: imx: hdmi: Convert binding to YAML dt-bindings: display: rockchip: dw-hdmi: Convert binding to YAML dt-bindings: display: sun8i-a83t-dw-hdmi: Reference dw-hdmi YAML schema dt-bindings: display: bridge: Remove deprecated dw_hdmi.txt .../display/allwinner,sun8i-a83t-dw-hdmi.yaml | 4 +- .../bindings/display/bridge/dw_hdmi.txt | 33 ---- .../display/bridge/renesas,dw-hdmi.txt | 86 --------- .../display/bridge/renesas,dw-hdmi.yaml | 142 ++++++++++++++ .../display/bridge/synopsys,dw-hdmi.yaml | 68 +++++++ .../bindings/display/imx/fsl,imx6-hdmi.yaml | 143 ++++++++++++++ .../devicetree/bindings/display/imx/hdmi.txt | 65 ------- .../display/rockchip/dw_hdmi-rockchip.txt | 74 -------- .../display/rockchip/rockchip,dw-hdmi.yaml | 178 ++++++++++++++++++ 9 files changed, 533 insertions(+), 260 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/bridge/dw_hdmi.txt delete mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt create mode 100644 Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.yaml create mode 100644 Documentation/devicetree/bindings/display/bridge/synopsys,dw-hdmi.yaml create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx6-hdmi.yaml delete mode 100644 Documentation/devicetree/bindings/display/imx/hdmi.txt delete mode 100644 Documentation/devicetree/bindings/display/rockchip/dw_hdmi-rockchip.txt create mode 100644 Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi.yaml