| Message ID | 20200406003656.2383978-1-bjorn.andersson@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: qcom: common: Silence EPROBE_DEFER messages | expand |
On Sun, Apr 05, 2020 at 05:36:56PM -0700, Bjorn Andersson wrote: > The Qualcomm sound card typically depends on several other drivers, > resulting in plenty of noise in the kernel log due to probe deferral. > Silence these errors. This then means that if something is missing a depdenceny it becomes impossible to tell what the problem is from the logs. Please at most reduce these to a dev_dbg().
diff --git a/sound/soc/qcom/common.c b/sound/soc/qcom/common.c index 6c20bdd850f3..cb266d7ec03e 100644 --- a/sound/soc/qcom/common.c +++ b/sound/soc/qcom/common.c @@ -80,7 +80,8 @@ int qcom_snd_parse_of(struct snd_soc_card *card) ret = snd_soc_of_get_dai_name(cpu, &link->cpus->dai_name); if (ret) { - dev_err(card->dev, "%s: error getting cpu dai name\n", link->name); + if (ret != -EPROBE_DEFER) + dev_err(card->dev, "%s: error getting cpu dai name", link->name); goto err; } @@ -96,7 +97,8 @@ int qcom_snd_parse_of(struct snd_soc_card *card) ret = snd_soc_of_get_dai_link_codecs(dev, codec, link); if (ret < 0) { - dev_err(card->dev, "%s: codec dai not found\n", link->name); + if (ret != -EPROBE_DEFER) + dev_err(card->dev, "%s: codec dai not found\n", link->name); goto err; } link->no_pcm = 1;
The Qualcomm sound card typically depends on several other drivers, resulting in plenty of noise in the kernel log due to probe deferral. Silence these errors. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- sound/soc/qcom/common.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)