diff mbox series

selftests/ftrace: Add CONFIG_SAMPLE_FTRACE_DIRECT=m kconfig

Message ID 20200405014457.8854-1-yangx.jy@cn.fujitsu.com (mailing list archive)
State Mainlined
Commit cdfe56d9012bcff266880177c4c7caf9821f63b0
Headers show
Series selftests/ftrace: Add CONFIG_SAMPLE_FTRACE_DIRECT=m kconfig | expand

Commit Message

Xiao Yang April 5, 2020, 1:44 a.m. UTC
ftrace-direct.tc and kprobe-direct.tc require CONFIG_SAMPLE_FTRACE_DIRECT=m
so add it to config file which is used by merge_config.sh.

Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
---
 tools/testing/selftests/ftrace/config | 1 +
 1 file changed, 1 insertion(+)

Comments

Steven Rostedt April 6, 2020, 1:23 p.m. UTC | #1
On Sun, 5 Apr 2020 09:44:57 +0800
Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:

> ftrace-direct.tc and kprobe-direct.tc require CONFIG_SAMPLE_FTRACE_DIRECT=m
> so add it to config file which is used by merge_config.sh.


Shuah,

Care to take this in your tree?

Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> 
> Signed-off-by: Xiao Yang <yangx.jy@cn.fujitsu.com>
> ---
>  tools/testing/selftests/ftrace/config | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
> index c2c8de4fafff..e59d985eeff0 100644
> --- a/tools/testing/selftests/ftrace/config
> +++ b/tools/testing/selftests/ftrace/config
> @@ -11,5 +11,6 @@ CONFIG_PREEMPTIRQ_DELAY_TEST=m
>  CONFIG_MODULES=y
>  CONFIG_MODULE_UNLOAD=y
>  CONFIG_SAMPLES=y
> +CONFIG_SAMPLE_FTRACE_DIRECT=m
>  CONFIG_SAMPLE_TRACE_PRINTK=m
>  CONFIG_KALLSYMS_ALL=y
Shuah Khan April 6, 2020, 2:52 p.m. UTC | #2
On 4/6/20 7:23 AM, Steven Rostedt wrote:
> On Sun, 5 Apr 2020 09:44:57 +0800
> Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:
> 
>> ftrace-direct.tc and kprobe-direct.tc require CONFIG_SAMPLE_FTRACE_DIRECT=m
>> so add it to config file which is used by merge_config.sh.
> 
> 
> Shuah,
> 
> Care to take this in your tree?
> 
> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 

Yes. I will apply this for next rc.

thanks,
-- Shuah
Shuah Khan April 30, 2020, 5:05 p.m. UTC | #3
Hi Xiao Yang,

On 4/6/20 8:52 AM, Shuah Khan wrote:
> On 4/6/20 7:23 AM, Steven Rostedt wrote:
>> On Sun, 5 Apr 2020 09:44:57 +0800
>> Xiao Yang <yangx.jy@cn.fujitsu.com> wrote:
>>
>>> ftrace-direct.tc and kprobe-direct.tc require 
>>> CONFIG_SAMPLE_FTRACE_DIRECT=m
>>> so add it to config file which is used by merge_config.sh.
>>
>>
>> Shuah,
>>
>> Care to take this in your tree?
>>
>> Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
>>
> 

I took this patch and sending it in my pull request. Please
make sure your commit logs don't wrap in your future patches.
It makes it easier to read commit logs.

"Without CONFIG_DYNAMIC_FTRACE, some tests get failure because required
     filter 
files(set_ftrace_filter/available_filter_functions/stack_trace_filter)
     are missing.  So implement check_filter_file() and make all related 
tests
     check required filter files by it.

     BTW: set_ftrace_filter and available_filter_functions are 
introduced together
     so just check either of them."


thanks,
-- Shuah
diff mbox series

Patch

diff --git a/tools/testing/selftests/ftrace/config b/tools/testing/selftests/ftrace/config
index c2c8de4fafff..e59d985eeff0 100644
--- a/tools/testing/selftests/ftrace/config
+++ b/tools/testing/selftests/ftrace/config
@@ -11,5 +11,6 @@  CONFIG_PREEMPTIRQ_DELAY_TEST=m
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
 CONFIG_SAMPLES=y
+CONFIG_SAMPLE_FTRACE_DIRECT=m
 CONFIG_SAMPLE_TRACE_PRINTK=m
 CONFIG_KALLSYMS_ALL=y