[v5,0/4] cleanup on do_pages_move()

Message

Wei Yang Feb. 14, 2020, 12:30 a.m. UTC

The logic in do_pages_move() is a little mess for audience to read and has
some potential error on handling the return value. Especially there are
three calls on do_move_pages_to_node() and store_status() with almost the
same form.

This patch set tries to make the code a little friendly for audience by
consolidate the calls.

v5:
  : rebase on top of latest upstream, "linux/pipe_fs_i.h: fix kernel-doc
    warnings after @wait was split"
v4:
  * rephrase changelog based on suggestion from David Hildenbrand
  * trivial change on code style and comment
v3:
  * rebase on top of Yang Shi's fix "mm: move_pages: report the number of
    non-attempted pages"
v2:
  * remove some unnecessary cleanup


Wei Yang (4):
  mm/migrate.c: no need to check for i > start in do_pages_move()
  mm/migrate.c: wrap do_move_pages_to_node() and store_status()
  mm/migrate.c: check pagelist in move_pages_and_store_status()
  mm/migrate.c: unify "not queued for migration" handling in
    do_pages_move()

 mm/migrate.c | 88 +++++++++++++++++++++++-----------------------------
 1 file changed, 39 insertions(+), 49 deletions(-)

Comments

Wei Yang April 7, 2020, 12:45 p.m. UTC | #1

On Fri, Feb 14, 2020 at 08:30:13AM +0800, Wei Yang wrote:
>The logic in do_pages_move() is a little mess for audience to read and has
>some potential error on handling the return value. Especially there are
>three calls on do_move_pages_to_node() and store_status() with almost the
>same form.

Sounds this patch set is not picked up yet.

Any thing else I need to do?