diff mbox series

test/example-advertisement: Fix advertising when discoverable

Message ID 20200409103035.96589-1-szymon.janc@codecoup.pl (mailing list archive)
State Accepted
Delegated to: Luiz Von Dentz
Headers show
Series test/example-advertisement: Fix advertising when discoverable | expand

Commit Message

Szymon Janc April 9, 2020, 10:30 a.m. UTC 
If adapter is discoverable (or LE-only) advertising was failing due
to too big adv data being set. Make sure there is enough space left
for flags if needed.
---
 test/example-advertisement | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Luiz Augusto von Dentz April 9, 2020, 6:29 p.m. UTC | #1 
Hi Szymon,

On Thu, Apr 9, 2020 at 3:33 AM Szymon Janc <szymon.janc@codecoup.pl> wrote:
>
> If adapter is discoverable (or LE-only) advertising was failing due
> to too big adv data being set. Make sure there is enough space left
> for flags if needed.
> ---
>  test/example-advertisement | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/example-advertisement b/test/example-advertisement
> index 88a27ab34..f116893b6 100755
> --- a/test/example-advertisement
> +++ b/test/example-advertisement
> @@ -142,7 +142,7 @@ class TestAdvertisement(Advertisement):
>          Advertisement.__init__(self, bus, index, 'peripheral')
>          self.add_service_uuid('180D')
>          self.add_service_uuid('180F')
> -        self.add_manufacturer_data(0xffff, [0x00, 0x01, 0x02, 0x03, 0x04])
> +        self.add_manufacturer_data(0xffff, [0x00, 0x01, 0x02, 0x03])
>          self.add_service_data('9999', [0x00, 0x01, 0x02, 0x03, 0x04])
>          self.add_local_name('TestAdvertisement')
>          self.include_tx_power = True
> --
> 2.25.2

Applied, thanks.
diff mbox series

Patch

diff --git a/test/example-advertisement b/test/example-advertisement
index 88a27ab34..f116893b6 100755
--- a/test/example-advertisement
+++ b/test/example-advertisement
@@ -142,7 +142,7 @@  class TestAdvertisement(Advertisement):
         Advertisement.__init__(self, bus, index, 'peripheral')
         self.add_service_uuid('180D')
         self.add_service_uuid('180F')
-        self.add_manufacturer_data(0xffff, [0x00, 0x01, 0x02, 0x03, 0x04])
+        self.add_manufacturer_data(0xffff, [0x00, 0x01, 0x02, 0x03])
         self.add_service_data('9999', [0x00, 0x01, 0x02, 0x03, 0x04])
         self.add_local_name('TestAdvertisement')
         self.include_tx_power = True