| Message ID | 20200331121352.3825-2-jbx6244@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RFC,v3,1/2] dt-bindings: sram: convert rockchip-pmu-sram bindings to yaml | expand |
On Tue, Mar 31, 2020 at 02:13:52PM +0200, Johan Jonker wrote: > A test with the command below gives for example these warnings: > > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > '#address-cells' is a required property > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > '#size-cells' is a required property > arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: > 'ranges' is a required property > > Fix this error by adding '#address-cells', '#size-cells' and > 'ranges' to the 'rockchip,rk3288-pmu-sram' compatible node > in rk3288.dtsi. > > make ARCH=arm dtbs_check > DT_SCHEMA_FILES=Documentation/devicetree/bindings/sram/sram.yaml > > Signed-off-by: Johan Jonker <jbx6244@gmail.com> > --- > Not tested with hardware. > > Changed v2: > Fix dtsi. > --- > arch/arm/boot/dts/rk3288.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi > index 9c8741bb1..f102fec69 100644 > --- a/arch/arm/boot/dts/rk3288.dtsi > +++ b/arch/arm/boot/dts/rk3288.dtsi > @@ -730,6 +730,9 @@ > pmu_sram: sram@ff720000 { > compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; > reg = <0x0 0xff720000 0x0 0x1000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x0 0xff720000 0x1000>; I think we should make these optional instead if there's no child nodes. And if there are child nodes, then these will be required. Rob
diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 9c8741bb1..f102fec69 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -730,6 +730,9 @@ pmu_sram: sram@ff720000 { compatible = "rockchip,rk3288-pmu-sram", "mmio-sram"; reg = <0x0 0xff720000 0x0 0x1000>; + #address-cells = <1>; + #size-cells = <1>; + ranges = <0 0x0 0xff720000 0x1000>; }; pmu: power-management@ff730000 {
A test with the command below gives for example these warnings: arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: '#address-cells' is a required property arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: '#size-cells' is a required property arch/arm/boot/dts/rk3288-evb-act8846.dt.yaml: sram@ff720000: 'ranges' is a required property Fix this error by adding '#address-cells', '#size-cells' and 'ranges' to the 'rockchip,rk3288-pmu-sram' compatible node in rk3288.dtsi. make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/sram/sram.yaml Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- Not tested with hardware. Changed v2: Fix dtsi. --- arch/arm/boot/dts/rk3288.dtsi | 3 +++ 1 file changed, 3 insertions(+)