[v3,0/5] mm/page_alloc.c: cleanup on check page

Message

Wei Yang April 11, 2020, 10:03 p.m. UTC

The patch set does some cleanup related to check page.

1. Remove unnecessary bad_reason assignment
2. Remove bad_flags to bad_page()
3. Rename function for naming convention
4. Extract common part to check page

Thanks suggestions from David Rientjes and Anshuman Khandual.

Wei Yang (5):
  mm/page_alloc.c: bad_[reason|flags] is not necessary when PageHWPoison
  mm/page_alloc.c: bad_flags is not necessary for bad_page()
  mm/page_alloc.c: rename free_pages_check_bad() to
    check_free_page_bad()
  mm/page_alloc.c: rename free_pages_check() to check_free_page()
  mm/page_alloc.c: extract check_[new|free]_page_bad() common part to
    page_bad_reason()

 mm/page_alloc.c | 74 +++++++++++++++++++------------------------------
 1 file changed, 28 insertions(+), 46 deletions(-)

Comments

Wei Yang April 11, 2020, 10:06 p.m. UTC | #1

On Sat, Apr 11, 2020 at 10:03:52PM +0000, Wei Yang wrote:
>The patch set does some cleanup related to check page.
>
>1. Remove unnecessary bad_reason assignment
>2. Remove bad_flags to bad_page()
>3. Rename function for naming convention
>4. Extract common part to check page
>
>Thanks suggestions from David Rientjes and Anshuman Khandual.

Oops, miss the history.

v3:
  * still just print the highest priority bad reason
  * remove the bad_flags to bad_page()

v2:
  * merge two rename patches into extract patch
  * enable dump several reasons for __dump_page()

>
>Wei Yang (5):
>  mm/page_alloc.c: bad_[reason|flags] is not necessary when PageHWPoison
>  mm/page_alloc.c: bad_flags is not necessary for bad_page()
>  mm/page_alloc.c: rename free_pages_check_bad() to
>    check_free_page_bad()
>  mm/page_alloc.c: rename free_pages_check() to check_free_page()
>  mm/page_alloc.c: extract check_[new|free]_page_bad() common part to
>    page_bad_reason()
>
> mm/page_alloc.c | 74 +++++++++++++++++++------------------------------
> 1 file changed, 28 insertions(+), 46 deletions(-)
>
>-- 
>2.23.0