| Message ID | b893d0449886a8ffed00bbcc1fcbe34d83b833d3.1586925868.git.matti.vaittinen@fi.rohmeurope.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Support ROHM BD99954 charger IC | expand |
On Wed, Apr 15, 2020 at 08:24:14AM +0300, Matti Vaittinen wrote: > The "default n" is not needed. Clean the KConfig by removing > "default n". > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> > --- > > This was pointed to me first by Randy Dunlap during v4 review. > I cleaned the BD99954 back then. > > Also Andy Shevchenko mentioned this to me. So as I was > changing the file anyways... Please just drop this patch out > of the series if you're not Ok with this. > > drivers/power/supply/Kconfig | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig > index ec028e47c3c2..04821d8c9e43 100644 > --- a/drivers/power/supply/Kconfig > +++ b/drivers/power/supply/Kconfig > @@ -660,7 +660,6 @@ config CHARGER_RT9455 > config CHARGER_CROS_USBPD > tristate "ChromeOS EC based USBPD charger" > depends on CROS_USBPD_NOTIFY > - default n > help > Say Y here to enable ChromeOS EC based USBPD charger > driver. This driver gets various bits of information about > @@ -696,7 +695,6 @@ config CHARGER_BD70528 > tristate "ROHM bd70528 charger driver" > depends on MFD_ROHM_BD70528 > select LINEAR_RANGES > - default n > help > Say Y here to enable support for getting battery status > information and altering charger configurations from charger > -- > 2.21.0 > > > -- > Matti Vaittinen, Linux device drivers > ROHM Semiconductors, Finland SWDC > Kiviharjunlenkki 1E > 90220 OULU > FINLAND > > ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ > Simon says - in Latin please. > ~~~ "non cogito me" dixit Rene Descarte, deinde evanescavit ~~~ > Thanks to Simon Glass for the translation =]
diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig index ec028e47c3c2..04821d8c9e43 100644 --- a/drivers/power/supply/Kconfig +++ b/drivers/power/supply/Kconfig @@ -660,7 +660,6 @@ config CHARGER_RT9455 config CHARGER_CROS_USBPD tristate "ChromeOS EC based USBPD charger" depends on CROS_USBPD_NOTIFY - default n help Say Y here to enable ChromeOS EC based USBPD charger driver. This driver gets various bits of information about @@ -696,7 +695,6 @@ config CHARGER_BD70528 tristate "ROHM bd70528 charger driver" depends on MFD_ROHM_BD70528 select LINEAR_RANGES - default n help Say Y here to enable support for getting battery status information and altering charger configurations from charger
The "default n" is not needed. Clean the KConfig by removing "default n". Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> --- This was pointed to me first by Randy Dunlap during v4 review. I cleaned the BD99954 back then. Also Andy Shevchenko mentioned this to me. So as I was changing the file anyways... Please just drop this patch out of the series if you're not Ok with this. drivers/power/supply/Kconfig | 2 -- 1 file changed, 2 deletions(-)