| Message ID | 20200415150244.2737206-2-robert.marko@sartura.hr (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3,1/3] net: phy: mdio: add IPQ40xx MDIO driver | expand |
On Wed, Apr 15, 2020 at 05:02:46PM +0200, Robert Marko wrote: > This patch adds the binding document for the IPQ40xx MDIO driver. > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > Cc: Luka Perkov <luka.perkov@sartura.hr> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On 4/15/2020 8:02 AM, Robert Marko wrote: > This patch adds the binding document for the IPQ40xx MDIO driver. > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > Cc: Luka Perkov <luka.perkov@sartura.hr> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> Please do not drop tags when they were given to you in an earlier version.
On Thu, Apr 16, 2020 at 1:55 AM Florian Fainelli <f.fainelli@gmail.com> wrote: > > > > On 4/15/2020 8:02 AM, Robert Marko wrote: > > This patch adds the binding document for the IPQ40xx MDIO driver. > > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > Cc: Luka Perkov <luka.perkov@sartura.hr> > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > > Please do not drop tags when they were given to you in an earlier version. Sorry, I did not know that. Wont do it in future, thanks > -- > Florian
On Wed, Apr 15, 2020 at 05:02:46PM +0200, Robert Marko wrote: > This patch adds the binding document for the IPQ40xx MDIO driver. > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > Cc: Luka Perkov <luka.perkov@sartura.hr> > --- > Changes from v2 to v3: > * Remove status from example > > .../bindings/net/qcom,ipq40xx-mdio.yaml | 61 +++++++++++++++++++ > 1 file changed, 61 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml > new file mode 100644 > index 000000000000..8d4542ccd38c > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml > @@ -0,0 +1,61 @@ > +# SPDX-License-Identifier: GPL-2.0 Dual license new bindings please: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/qcom,ipq40xx-mdio.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm IPQ40xx MDIO Controller Device Tree Bindings > + > +maintainers: > + - Robert Marko <robert.marko@sartura.hr> > + > +allOf: > + - $ref: "mdio.yaml#" > + > +properties: > + compatible: > + const: qcom,ipq40xx-mdio Don't use wildcards in compatible names. Should be SoC specific. If 'all the same', then use a fallback to the 1st implementation. > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 0 > + > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - "#address-cells" > + - "#size-cells" > + > +examples: > + - | > + mdio@90000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "qcom,ipq40xx-mdio"; > + reg = <0x90000 0x64>; > + > + ethphy0: ethernet-phy@0 { > + reg = <0>; > + }; > + > + ethphy1: ethernet-phy@1 { > + reg = <1>; > + }; > + > + ethphy2: ethernet-phy@2 { > + reg = <2>; > + }; > + > + ethphy3: ethernet-phy@3 { > + reg = <3>; > + }; > + > + ethphy4: ethernet-phy@4 { > + reg = <4>; > + }; > + }; > -- > 2.26.0 >
On Tue, Apr 28, 2020 at 5:09 PM Rob Herring <robh@kernel.org> wrote: > > On Wed, Apr 15, 2020 at 05:02:46PM +0200, Robert Marko wrote: > > This patch adds the binding document for the IPQ40xx MDIO driver. > > > > Signed-off-by: Robert Marko <robert.marko@sartura.hr> > > Cc: Luka Perkov <luka.perkov@sartura.hr> > > --- > > Changes from v2 to v3: > > * Remove status from example > > > > .../bindings/net/qcom,ipq40xx-mdio.yaml | 61 +++++++++++++++++++ > > 1 file changed, 61 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml > > > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml > > new file mode 100644 > > index 000000000000..8d4542ccd38c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml > > @@ -0,0 +1,61 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > Dual license new bindings please: > > (GPL-2.0-only OR BSD-2-Clause) Ok, will change it in next revision. > > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/net/qcom,ipq40xx-mdio.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm IPQ40xx MDIO Controller Device Tree Bindings > > + > > +maintainers: > > + - Robert Marko <robert.marko@sartura.hr> > > + > > +allOf: > > + - $ref: "mdio.yaml#" > > + > > +properties: > > + compatible: > > + const: qcom,ipq40xx-mdio > > Don't use wildcards in compatible names. Should be SoC specific. If 'all > the same', then use a fallback to the 1st implementation. Ok, I will change it to qcom,ipq4019 then. The whole IPQ40xx series uses the same controller. > > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + - "#address-cells" > > + - "#size-cells" > > + > > +examples: > > + - | > > + mdio@90000 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + compatible = "qcom,ipq40xx-mdio"; > > + reg = <0x90000 0x64>; > > + > > + ethphy0: ethernet-phy@0 { > > + reg = <0>; > > + }; > > + > > + ethphy1: ethernet-phy@1 { > > + reg = <1>; > > + }; > > + > > + ethphy2: ethernet-phy@2 { > > + reg = <2>; > > + }; > > + > > + ethphy3: ethernet-phy@3 { > > + reg = <3>; > > + }; > > + > > + ethphy4: ethernet-phy@4 { > > + reg = <4>; > > + }; > > + }; > > -- > > 2.26.0 > >
diff --git a/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml new file mode 100644 index 000000000000..8d4542ccd38c --- /dev/null +++ b/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml @@ -0,0 +1,61 @@ +# SPDX-License-Identifier: GPL-2.0 +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/qcom,ipq40xx-mdio.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm IPQ40xx MDIO Controller Device Tree Bindings + +maintainers: + - Robert Marko <robert.marko@sartura.hr> + +allOf: + - $ref: "mdio.yaml#" + +properties: + compatible: + const: qcom,ipq40xx-mdio + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + reg: + maxItems: 1 + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +examples: + - | + mdio@90000 { + #address-cells = <1>; + #size-cells = <0>; + compatible = "qcom,ipq40xx-mdio"; + reg = <0x90000 0x64>; + + ethphy0: ethernet-phy@0 { + reg = <0>; + }; + + ethphy1: ethernet-phy@1 { + reg = <1>; + }; + + ethphy2: ethernet-phy@2 { + reg = <2>; + }; + + ethphy3: ethernet-phy@3 { + reg = <3>; + }; + + ethphy4: ethernet-phy@4 { + reg = <4>; + }; + };
This patch adds the binding document for the IPQ40xx MDIO driver. Signed-off-by: Robert Marko <robert.marko@sartura.hr> Cc: Luka Perkov <luka.perkov@sartura.hr> --- Changes from v2 to v3: * Remove status from example .../bindings/net/qcom,ipq40xx-mdio.yaml | 61 +++++++++++++++++++ 1 file changed, 61 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml