| Message ID | 20200402110857.509844-1-colin.king@canonical.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 437fb760d046340d0dee3b4307e1cf4578fd8ca8 |
| Headers | show |
| Series | pwm: meson: remove redundant assignment to variable fin_freq | expand |
On Thu, Apr 02, 2020 at 12:08:57PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable fin_freq is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> This was introduced in 211ed630753d ("pwm: Add support for Meson PWM Controller"), adding Neil To Cc:. I don't think this was added to cope for a compiler not being able to see the variable is used initialized only. Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe > diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c > index 8cf9129caa39..bd0d7336b898 100644 > --- a/drivers/pwm/pwm-meson.c > +++ b/drivers/pwm/pwm-meson.c > @@ -163,7 +163,7 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm, > { > struct meson_pwm_channel *channel = pwm_get_chip_data(pwm); > unsigned int duty, period, pre_div, cnt, duty_cnt; > - unsigned long fin_freq = -1; > + unsigned long fin_freq; > > duty = state->duty_cycle; > period = state->period;
On Thu, Apr 02, 2020 at 12:08:57PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable fin_freq is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/pwm/pwm-meson.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. Thierry
Hello: This patch was applied to khilman/linux-amlogic.git (refs/heads/for-next). On Thu, 2 Apr 2020 12:08:57 +0100 you wrote: > From: Colin Ian King <colin.king@canonical.com> > > The variable fin_freq is being initialized with a value that is never > read and it is being updated later with a new value. The initialization > is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > > [...] Here is a summary with links: - pwm: meson: remove redundant assignment to variable fin_freq https://git.kernel.org/khilman/linux-amlogic/c/437fb760d046340d0dee3b4307e1cf4578fd8ca8 You are awesome, thank you!
diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c index 8cf9129caa39..bd0d7336b898 100644 --- a/drivers/pwm/pwm-meson.c +++ b/drivers/pwm/pwm-meson.c @@ -163,7 +163,7 @@ static int meson_pwm_calc(struct meson_pwm *meson, struct pwm_device *pwm, { struct meson_pwm_channel *channel = pwm_get_chip_data(pwm); unsigned int duty, period, pre_div, cnt, duty_cnt; - unsigned long fin_freq = -1; + unsigned long fin_freq; duty = state->duty_cycle; period = state->period;