| Message ID | 20200403094904.37072-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | de0c4eb44c39cbb2b3b11bac699b618b0f8d4142 |
| Headers | show |
| Series | [v2] MIPS: TXx9: Fix Kconfig warnings | expand |
On Fri, Apr 03, 2020 at 05:49:04PM +0800, YueHaibing wrote: > If TTY and SND is not n, we got this warnings: > > WARNING: unmet direct dependencies detected for HAS_TXX9_SERIAL > Depends on [n]: TTY [=n] && HAS_IOMEM [=y] > Selected by [y]: > - SOC_TX3927 [=y] > > WARNING: unmet direct dependencies detected for HAS_TXX9_SERIAL > Depends on [n]: TTY [=n] && HAS_IOMEM [=y] > Selected by [y]: > - SOC_TX4938 [=y] > > Only dependencies is enabled, they can be enabled, so > use 'imply' instead of 'select' to fix this. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > v2: fix patch title > --- > arch/mips/txx9/Kconfig | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) applied to mips-next. Thomas.
diff --git a/arch/mips/txx9/Kconfig b/arch/mips/txx9/Kconfig index 9a22a182b7a4..85c4c121c71f 100644 --- a/arch/mips/txx9/Kconfig +++ b/arch/mips/txx9/Kconfig @@ -58,7 +58,7 @@ config TOSHIBA_RBTX4939 config SOC_TX3927 bool select CEVT_TXX9 - select HAS_TXX9_SERIAL + imply HAS_TXX9_SERIAL select HAVE_PCI select IRQ_TXX9 select GPIO_TXX9 @@ -66,30 +66,30 @@ config SOC_TX3927 config SOC_TX4927 bool select CEVT_TXX9 - select HAS_TXX9_SERIAL + imply HAS_TXX9_SERIAL select HAVE_PCI select IRQ_TXX9 select PCI_TX4927 select GPIO_TXX9 - select HAS_TXX9_ACLC + imply HAS_TXX9_ACLC config SOC_TX4938 bool select CEVT_TXX9 - select HAS_TXX9_SERIAL + imply HAS_TXX9_SERIAL select HAVE_PCI select IRQ_TXX9 select PCI_TX4927 select GPIO_TXX9 - select HAS_TXX9_ACLC + imply HAS_TXX9_ACLC config SOC_TX4939 bool select CEVT_TXX9 - select HAS_TXX9_SERIAL + imply HAS_TXX9_SERIAL select HAVE_PCI select PCI_TX4927 - select HAS_TXX9_ACLC + imply HAS_TXX9_ACLC config TXX9_7SEGLED bool
If TTY and SND is not n, we got this warnings: WARNING: unmet direct dependencies detected for HAS_TXX9_SERIAL Depends on [n]: TTY [=n] && HAS_IOMEM [=y] Selected by [y]: - SOC_TX3927 [=y] WARNING: unmet direct dependencies detected for HAS_TXX9_SERIAL Depends on [n]: TTY [=n] && HAS_IOMEM [=y] Selected by [y]: - SOC_TX4938 [=y] Only dependencies is enabled, they can be enabled, so use 'imply' instead of 'select' to fix this. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- v2: fix patch title --- arch/mips/txx9/Kconfig | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)