| Message ID | 1586274430-28402-4-git-send-email-kgunda@codeaurora.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for WLED5 | expand |
On Tue, Apr 07, 2020 at 09:17:09PM +0530, Kiran Gunda wrote: > Add WLED5 specific bindings. > checkpatch.pl complains about some trailing whitespace. The previous patch too. > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> > Signed-off-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org> > --- > .../bindings/leds/backlight/qcom-wled.yaml | 60 ++++++++++++++++++++-- > 1 file changed, 57 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > index 770e780..5714631 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > @@ -21,6 +21,7 @@ properties: > - qcom,pm8941-wled > - qcom,pmi8998-wled > - qcom,pm660l-wled > + - qcom,pm8150l-wled > > reg: > maxItems: 1 > @@ -28,12 +29,13 @@ properties: > default-brightness: > description: > brightness value on boot. > - minimum: 0 > - maximum: 4095 > - default: 2048 > > label: true > > + max-brightness: > + description: > + Maximum brightness level. > + > qcom,cs-out: > description: > enable current sink output. > @@ -130,6 +132,31 @@ properties: > This feature is not supported for WLED3. > type: boolean > > + qcom,modulator-sel: > + description: Need a '|' at the end to preserve formatting. > + Selects the modulator used for brightness modulation. > + Allowed values are, > + 0 - Modulator A > + 1 - Modulator B > + This property is applicable only to WLED5 peripheral. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - enum: [ 0, 1 ] > + - default: 0 > + > + qcom,cabc-sel: > + description: Need a '|'. > + Selects the CABC pin signal used for brightness modulation. > + Allowed values are, > + 0 - CABC disabled > + 1 - CABC 1 > + 2 - CABC 2 > + 3 - External signal (e.g. LPG) is used for dimming > + This property is applicable only to WLED5 peripheral. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - enum: [ 0, 1, 2, 3 ] > + > allOf: > - if: > properties: > @@ -179,6 +206,33 @@ allOf: > - const: ovp > - const: short > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pm8150l-wled > + > + then: > + properties: > + default-brightness: > + minimum: 0 > + maximum: 32767 > + > + max-brightness: > + minimum: 0 > + maximum: 32767 > + > + else: > + properties: > + default-brightness: > + minimum: 0 > + maximum: 4095 Wrong indentation. > + > + max-brightness: > + minimum: 0 > + maximum: 4095 > + > required: > - compatible > - reg > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
On 2020-04-15 20:42, Rob Herring wrote: > On Tue, Apr 07, 2020 at 09:17:09PM +0530, Kiran Gunda wrote: >> Add WLED5 specific bindings. >> > > checkpatch.pl complains about some trailing whitespace. The previous > patch too. > >> Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> >> Signed-off-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org> >> --- >> .../bindings/leds/backlight/qcom-wled.yaml | 60 >> ++++++++++++++++++++-- >> 1 file changed, 57 insertions(+), 3 deletions(-) >> >> diff --git >> a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml >> b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml >> index 770e780..5714631 100644 >> --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml >> +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml >> @@ -21,6 +21,7 @@ properties: >> - qcom,pm8941-wled >> - qcom,pmi8998-wled >> - qcom,pm660l-wled >> + - qcom,pm8150l-wled >> >> reg: >> maxItems: 1 >> @@ -28,12 +29,13 @@ properties: >> default-brightness: >> description: >> brightness value on boot. >> - minimum: 0 >> - maximum: 4095 >> - default: 2048 >> >> label: true >> >> + max-brightness: >> + description: >> + Maximum brightness level. >> + >> qcom,cs-out: >> description: >> enable current sink output. >> @@ -130,6 +132,31 @@ properties: >> This feature is not supported for WLED3. >> type: boolean >> >> + qcom,modulator-sel: >> + description: > > Need a '|' at the end to preserve formatting. > >> + Selects the modulator used for brightness modulation. >> + Allowed values are, >> + 0 - Modulator A >> + 1 - Modulator B >> + This property is applicable only to WLED5 peripheral. >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 >> + - enum: [ 0, 1 ] >> + - default: 0 >> + >> + qcom,cabc-sel: >> + description: > > Need a '|'. > >> + Selects the CABC pin signal used for brightness modulation. >> + Allowed values are, >> + 0 - CABC disabled >> + 1 - CABC 1 >> + 2 - CABC 2 >> + 3 - External signal (e.g. LPG) is used for dimming >> + This property is applicable only to WLED5 peripheral. >> + allOf: >> + - $ref: /schemas/types.yaml#/definitions/uint32 >> + - enum: [ 0, 1, 2, 3 ] >> + >> allOf: >> - if: >> properties: >> @@ -179,6 +206,33 @@ allOf: >> - const: ovp >> - const: short >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - qcom,pm8150l-wled >> + >> + then: >> + properties: >> + default-brightness: >> + minimum: 0 >> + maximum: 32767 >> + >> + max-brightness: >> + minimum: 0 >> + maximum: 32767 >> + >> + else: >> + properties: >> + default-brightness: >> + minimum: 0 >> + maximum: 4095 > > Wrong indentation. > >> + >> + max-brightness: >> + minimum: 0 >> + maximum: 4095 >> + >> required: >> - compatible >> - reg >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project >> Thanks for reviewing. I will submit the next revision with all the fixes.
On Tue, Apr 07, 2020 at 09:17:09PM +0530, Kiran Gunda wrote: > Add WLED5 specific bindings. > > Signed-off-by: Kiran Gunda <kgunda@codeaurora.org> > Signed-off-by: Subbaraman Narayanamurthy <subbaram@codeaurora.org> If v6 is just reacting to Rob's feedback then feel free to add the following when you recirculate: Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > .../bindings/leds/backlight/qcom-wled.yaml | 60 ++++++++++++++++++++-- > 1 file changed, 57 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > index 770e780..5714631 100644 > --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml > @@ -21,6 +21,7 @@ properties: > - qcom,pm8941-wled > - qcom,pmi8998-wled > - qcom,pm660l-wled > + - qcom,pm8150l-wled > > reg: > maxItems: 1 > @@ -28,12 +29,13 @@ properties: > default-brightness: > description: > brightness value on boot. > - minimum: 0 > - maximum: 4095 > - default: 2048 > > label: true > > + max-brightness: > + description: > + Maximum brightness level. > + > qcom,cs-out: > description: > enable current sink output. > @@ -130,6 +132,31 @@ properties: > This feature is not supported for WLED3. > type: boolean > > + qcom,modulator-sel: > + description: > + Selects the modulator used for brightness modulation. > + Allowed values are, > + 0 - Modulator A > + 1 - Modulator B > + This property is applicable only to WLED5 peripheral. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - enum: [ 0, 1 ] > + - default: 0 > + > + qcom,cabc-sel: > + description: > + Selects the CABC pin signal used for brightness modulation. > + Allowed values are, > + 0 - CABC disabled > + 1 - CABC 1 > + 2 - CABC 2 > + 3 - External signal (e.g. LPG) is used for dimming > + This property is applicable only to WLED5 peripheral. > + allOf: > + - $ref: /schemas/types.yaml#/definitions/uint32 > + - enum: [ 0, 1, 2, 3 ] > + > allOf: > - if: > properties: > @@ -179,6 +206,33 @@ allOf: > - const: ovp > - const: short > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - qcom,pm8150l-wled > + > + then: > + properties: > + default-brightness: > + minimum: 0 > + maximum: 32767 > + > + max-brightness: > + minimum: 0 > + maximum: 32767 > + > + else: > + properties: > + default-brightness: > + minimum: 0 > + maximum: 4095 > + > + max-brightness: > + minimum: 0 > + maximum: 4095 > + > required: > - compatible > - reg > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project
diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml index 770e780..5714631 100644 --- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml +++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml @@ -21,6 +21,7 @@ properties: - qcom,pm8941-wled - qcom,pmi8998-wled - qcom,pm660l-wled + - qcom,pm8150l-wled reg: maxItems: 1 @@ -28,12 +29,13 @@ properties: default-brightness: description: brightness value on boot. - minimum: 0 - maximum: 4095 - default: 2048 label: true + max-brightness: + description: + Maximum brightness level. + qcom,cs-out: description: enable current sink output. @@ -130,6 +132,31 @@ properties: This feature is not supported for WLED3. type: boolean + qcom,modulator-sel: + description: + Selects the modulator used for brightness modulation. + Allowed values are, + 0 - Modulator A + 1 - Modulator B + This property is applicable only to WLED5 peripheral. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 0, 1 ] + - default: 0 + + qcom,cabc-sel: + description: + Selects the CABC pin signal used for brightness modulation. + Allowed values are, + 0 - CABC disabled + 1 - CABC 1 + 2 - CABC 2 + 3 - External signal (e.g. LPG) is used for dimming + This property is applicable only to WLED5 peripheral. + allOf: + - $ref: /schemas/types.yaml#/definitions/uint32 + - enum: [ 0, 1, 2, 3 ] + allOf: - if: properties: @@ -179,6 +206,33 @@ allOf: - const: ovp - const: short + - if: + properties: + compatible: + contains: + enum: + - qcom,pm8150l-wled + + then: + properties: + default-brightness: + minimum: 0 + maximum: 32767 + + max-brightness: + minimum: 0 + maximum: 32767 + + else: + properties: + default-brightness: + minimum: 0 + maximum: 4095 + + max-brightness: + minimum: 0 + maximum: 4095 + required: - compatible - reg