[mlx5-next,00/10] Add support to get xmit slave

Message

Maor Gottlieb April 19, 2020, 1:39 p.m. UTC

Hi Dave,

This series is a combination of netdev and RDMA, so in order to avoid
conflicts, we would like to ask you to route this series through
mlx5-next shared branch. It is based on v5.7-rc1 tag.

---------------------------------------------------------------------

The following series adds support to get the LAG master xmit slave by
introducing new .ndo - ndo_xmit_slave_get. Every LAG module can
implement it and it first implemented in the bond driver. 
This is follow-up to the RFC discussion [1].

The main motivation for doing this is for drivers that offload part
of the LAG functionality. For example, Mellanox Connect-X hardware
implements RoCE LAG which selects the TX affinity when the resources
are created and port is remapped when it goes down.

The first part of this patchset introduces the new .ndo and add the
support to the bonding module.

The second part adds support to get the RoCE LAG xmit slave by building
skb of the RoCE packet based on the AH attributes and call to the new .ndo.

The third part change the mlx5 driver driver to set the QP's affinity
port according to the slave which found by the .ndo.

Thanks

[1] https://lore.kernel.org/netdev/[e-mail]/

Maor Gottlieb (10):
  net/core: Introduce master_xmit_slave_get
  bonding: Rename slave_arr to usable_slaves
  bonding: Add helpers to get xmit slave
  bonding: Implement ndo_xmit_slave_get
  RDMA/core: Add LAG functionality
  RDMA/core: Get xmit slave for LAG
  net/mlx5: Change lag mutex lock to spin lock
  net/mlx5: Add support to get lag physical port
  RDMA/mlx5: Refactor affinity related code
  RDMA/mlx5: Set lag tx affinity according to slave

 drivers/infiniband/core/Makefile              |   2 +-
 drivers/infiniband/core/lag.c                 | 139 +++++++++
 drivers/infiniband/core/verbs.c               |  44 ++-
 drivers/infiniband/hw/mlx5/ah.c               |   4 +
 drivers/infiniband/hw/mlx5/gsi.c              |  34 ++-
 drivers/infiniband/hw/mlx5/main.c             |   2 +
 drivers/infiniband/hw/mlx5/mlx5_ib.h          |   1 +
 drivers/infiniband/hw/mlx5/qp.c               | 123 +++++---
 drivers/net/bonding/bond_alb.c                |  39 ++-
 drivers/net/bonding/bond_main.c               | 272 +++++++++++++-----
 drivers/net/ethernet/mellanox/mlx5/core/lag.c |  66 +++--
 include/linux/mlx5/driver.h                   |   2 +
 include/linux/mlx5/mlx5_ifc.h                 |   4 +-
 include/linux/mlx5/qp.h                       |   2 +
 include/linux/netdevice.h                     |   3 +
 include/net/bond_alb.h                        |   4 +
 include/net/bonding.h                         |   3 +-
 include/net/lag.h                             |  32 +++
 include/rdma/ib_verbs.h                       |   2 +
 include/rdma/lag.h                            |  22 ++
 20 files changed, 621 insertions(+), 179 deletions(-)
 create mode 100644 drivers/infiniband/core/lag.c
 create mode 100644 include/rdma/lag.h

Comments

David Ahern April 19, 2020, 7:44 p.m. UTC | #1

On 4/19/20 7:39 AM, Maor Gottlieb wrote:
> Hi Dave,
> 
> This series is a combination of netdev and RDMA, so in order to avoid
> conflicts, we would like to ask you to route this series through
> mlx5-next shared branch. It is based on v5.7-rc1 tag.
> 
> ---------------------------------------------------------------------
> 
> The following series adds support to get the LAG master xmit slave by
> introducing new .ndo - ndo_xmit_slave_get. Every LAG module can

I do not see ndo_xmit_slave_get  introduced ...


> 
>  drivers/infiniband/core/Makefile              |   2 +-
>  drivers/infiniband/core/lag.c                 | 139 +++++++++
>  drivers/infiniband/core/verbs.c               |  44 ++-
>  drivers/infiniband/hw/mlx5/ah.c               |   4 +
>  drivers/infiniband/hw/mlx5/gsi.c              |  34 ++-
>  drivers/infiniband/hw/mlx5/main.c             |   2 +
>  drivers/infiniband/hw/mlx5/mlx5_ib.h          |   1 +
>  drivers/infiniband/hw/mlx5/qp.c               | 123 +++++---
>  drivers/net/bonding/bond_alb.c                |  39 ++-
>  drivers/net/bonding/bond_main.c               | 272 +++++++++++++-----
>  drivers/net/ethernet/mellanox/mlx5/core/lag.c |  66 +++--
>  include/linux/mlx5/driver.h                   |   2 +
>  include/linux/mlx5/mlx5_ifc.h                 |   4 +-
>  include/linux/mlx5/qp.h                       |   2 +
>  include/linux/netdevice.h                     |   3 +

nor any changes to netdevice.h. Bad spin of the patches?