diff mbox series

[v2,1/4] selftests: kmod: Use variable NAME in kmod_test_0001()

Message ID 1587381782-31047-1-git-send-email-yangtiezhu@loongson.cn (mailing list archive)
State New
Headers show
Series [v2,1/4] selftests: kmod: Use variable NAME in kmod_test_0001() | expand

Commit Message

Tiezhu Yang April 20, 2020, 11:22 a.m. UTC 
Use the variable NAME instead of "\000" directly in kmod_test_0001().

Acked-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---

v2:
  - just add Acked-by tag

 tools/testing/selftests/kmod/kmod.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Markus Elfring April 20, 2020, 11:30 a.m. UTC | #1 
> Use the variable NAME instead of "\000" directly in kmod_test_0001().

Would this patch series have been a bit nicer together with
a cover letter?

Regards,
Markus
Tiezhu Yang April 20, 2020, 11:40 a.m. UTC | #2 
On 04/20/2020 07:30 PM, Markus Elfring wrote:
>> Use the variable NAME instead of "\000" directly in kmod_test_0001().
> Would this patch series have been a bit nicer together with
> a cover letter?

OK, thanks for your suggestion. I will resend it with a cover letter.

Thanks,
Tiezhu Yang

>
> Regards,
> Markus
Markus Elfring April 20, 2020, 12:12 p.m. UTC | #3 
> OK, thanks for your suggestion.

Thanks for your acceptance.


> I will resend it with a cover letter.

I guess that such a resend would be needed only
if another version for this patch series will be published.
It seems that the attention can occasionally grow also for
the usage of helpful cover letters.

Regards,
Markus
diff mbox series

Patch

diff --git a/tools/testing/selftests/kmod/kmod.sh b/tools/testing/selftests/kmod/kmod.sh
index 3702dbc..da60c3b 100755
--- a/tools/testing/selftests/kmod/kmod.sh
+++ b/tools/testing/selftests/kmod/kmod.sh
@@ -341,7 +341,7 @@  kmod_test_0001_driver()
 
 	kmod_defaults_driver
 	config_num_threads 1
-	printf '\000' >"$DIR"/config_test_driver
+	printf $NAME >"$DIR"/config_test_driver
 	config_trigger ${FUNCNAME[0]}
 	config_expect_result ${FUNCNAME[0]} MODULE_NOT_FOUND
 }
@@ -352,7 +352,7 @@  kmod_test_0001_fs()
 
 	kmod_defaults_fs
 	config_num_threads 1
-	printf '\000' >"$DIR"/config_test_fs
+	printf $NAME >"$DIR"/config_test_fs
 	config_trigger ${FUNCNAME[0]}
 	config_expect_result ${FUNCNAME[0]} -EINVAL
 }