Message ID | 20200420231601.16781-3-mathieu.poirier@linaro.org (mailing list archive) |
---|---|
State | Mainlined |
Commit | 9d5f82c8ba2471e34150a0e750ef54089e2a3740 |
Headers | show |
Series | remoteproc: Refactor function rproc_alloc() | expand |
On Mon 20 Apr 16:15 PDT 2020, Mathieu Poirier wrote: > Improve the readability of function rproc_alloc_firmware() by using > a non-negated condition and moving the comment out of the conditional > block > > Suggested-by: Alex Elder <elder@linaro.org> > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > Reviewed-by: Alex Elder <elder@linaro.org> Looks better, thanks for respinning. Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/remoteproc/remoteproc_core.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index db8a15fc1e4a..45529d40342f 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -2011,14 +2011,14 @@ static int rproc_alloc_firmware(struct rproc *rproc, > { > const char *p; > > - if (!firmware) > - /* > - * If the caller didn't pass in a firmware name then > - * construct a default name. > - */ > - p = kasprintf(GFP_KERNEL, "rproc-%s-fw", name); > - else > + /* > + * Allocate a firmware name if the caller gave us one to work > + * with. Otherwise construct a new one using a default pattern. > + */ > + if (firmware) > p = kstrdup_const(firmware, GFP_KERNEL); > + else > + p = kasprintf(GFP_KERNEL, "rproc-%s-fw", name); > > if (!p) > return -ENOMEM; > -- > 2.20.1 >
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index db8a15fc1e4a..45529d40342f 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -2011,14 +2011,14 @@ static int rproc_alloc_firmware(struct rproc *rproc, { const char *p; - if (!firmware) - /* - * If the caller didn't pass in a firmware name then - * construct a default name. - */ - p = kasprintf(GFP_KERNEL, "rproc-%s-fw", name); - else + /* + * Allocate a firmware name if the caller gave us one to work + * with. Otherwise construct a new one using a default pattern. + */ + if (firmware) p = kstrdup_const(firmware, GFP_KERNEL); + else + p = kasprintf(GFP_KERNEL, "rproc-%s-fw", name); if (!p) return -ENOMEM;