| Message ID | 20200421003135.23060-7-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,01/16] iio: adc: ad_sigma_delta: Use {get,put}_unaligned_be24() | expand |
> From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> > On Behalf Of Andy Shevchenko > Sent: Dienstag, 21. April 2020 02:31 > To: Jonathan Cameron <jic23@kernel.org>; Peter Meerwald-Stadler > <pmeerw@pmeerw.net>; linux-iio@vger.kernel.org > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Lars-Peter > Clausen <lars@metafoo.de>; Hennerich, Michael > <Michael.Hennerich@analog.com> > Subject: [PATCH v1 07/16] iio: gyro: adis16130: Use get_unaligned_be24() > > > This makes the driver code slightly easier to read. > > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/iio/gyro/adis16130.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Nuno Sá <nuno.sa@analog.com>
On Tue, 21 Apr 2020 06:39:39 +0000 "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > > From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> > > On Behalf Of Andy Shevchenko > > Sent: Dienstag, 21. April 2020 02:31 > > To: Jonathan Cameron <jic23@kernel.org>; Peter Meerwald-Stadler > > <pmeerw@pmeerw.net>; linux-iio@vger.kernel.org > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Lars-Peter > > Clausen <lars@metafoo.de>; Hennerich, Michael > > <Michael.Hennerich@analog.com> > > Subject: [PATCH v1 07/16] iio: gyro: adis16130: Use get_unaligned_be24() > > > > > > This makes the driver code slightly easier to read. > > > > Cc: Lars-Peter Clausen <lars@metafoo.de> > > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/iio/gyro/adis16130.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Acked-by: Nuno Sá <nuno.sa@analog.com> Applied with header added... J
diff --git a/drivers/iio/gyro/adis16130.c b/drivers/iio/gyro/adis16130.c index 79e63c8a2ea8..b8d626bc30ad 100644 --- a/drivers/iio/gyro/adis16130.c +++ b/drivers/iio/gyro/adis16130.c @@ -59,7 +59,7 @@ static int adis16130_spi_read(struct iio_dev *indio_dev, u8 reg_addr, u32 *val) ret = spi_sync_transfer(st->us, &xfer, 1); if (ret == 0) - *val = (st->buf[1] << 16) | (st->buf[2] << 8) | st->buf[3]; + *val = get_unaligned_be24(&st->buf[1]); mutex_unlock(&st->buf_lock); return ret;
This makes the driver code slightly easier to read. Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Michael Hennerich <Michael.Hennerich@analog.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/iio/gyro/adis16130.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)