| Message ID | 20200421003135.23060-5-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v1,01/16] iio: adc: ad_sigma_delta: Use {get,put}_unaligned_be24() | expand |
> From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> > On Behalf Of Andy Shevchenko > Sent: Dienstag, 21. April 2020 02:31 > To: Jonathan Cameron <jic23@kernel.org>; Peter Meerwald-Stadler > <pmeerw@pmeerw.net>; linux-iio@vger.kernel.org > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Lars-Peter > Clausen <lars@metafoo.de>; Hennerich, Michael > <Michael.Hennerich@analog.com> > Subject: [PATCH v1 05/16] iio: dac: ad5624r_spi: Use put_unaligned_be24() > > > This makes the driver code slightly easier to read. > > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/iio/dac/ad5624r_spi.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > Acked-by: Nuno Sá <nuno.sa@analog.com>
On Tue, 21 Apr 2020 06:43:44 +0000 "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > > From: linux-iio-owner@vger.kernel.org <linux-iio-owner@vger.kernel.org> > > On Behalf Of Andy Shevchenko > > Sent: Dienstag, 21. April 2020 02:31 > > To: Jonathan Cameron <jic23@kernel.org>; Peter Meerwald-Stadler > > <pmeerw@pmeerw.net>; linux-iio@vger.kernel.org > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>; Lars-Peter > > Clausen <lars@metafoo.de>; Hennerich, Michael > > <Michael.Hennerich@analog.com> > > Subject: [PATCH v1 05/16] iio: dac: ad5624r_spi: Use put_unaligned_be24() > > > > > > This makes the driver code slightly easier to read. > > > > Cc: Lars-Peter Clausen <lars@metafoo.de> > > Cc: Michael Hennerich <Michael.Hennerich@analog.com> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/iio/dac/ad5624r_spi.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > Acked-by: Nuno Sá <nuno.sa@analog.com> Applied with missing asm/unaligned header added. Thanks, J
diff --git a/drivers/iio/dac/ad5624r_spi.c b/drivers/iio/dac/ad5624r_spi.c index e6c022e1dc1c..394d9d23ba63 100644 --- a/drivers/iio/dac/ad5624r_spi.c +++ b/drivers/iio/dac/ad5624r_spi.c @@ -35,11 +35,9 @@ static int ad5624r_spi_write(struct spi_device *spi, * for the AD5664R, AD5644R, and AD5624R, respectively. */ data = (0 << 22) | (cmd << 19) | (addr << 16) | (val << shift); - msg[0] = data >> 16; - msg[1] = data >> 8; - msg[2] = data; + put_unaligned_be24(data, &msg[0]); - return spi_write(spi, msg, 3); + return spi_write(spi, msg, sizeof(msg)); } static int ad5624r_read_raw(struct iio_dev *indio_dev,
This makes the driver code slightly easier to read. Cc: Lars-Peter Clausen <lars@metafoo.de> Cc: Michael Hennerich <Michael.Hennerich@analog.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/iio/dac/ad5624r_spi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)